From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAB60C2D0DB for ; Wed, 29 Jan 2020 17:42:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC2E9206F0 for ; Wed, 29 Jan 2020 17:42:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="FBMHWlFO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727368AbgA2RmQ (ORCPT ); Wed, 29 Jan 2020 12:42:16 -0500 Received: from mail-io1-f48.google.com ([209.85.166.48]:35403 "EHLO mail-io1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726679AbgA2RmQ (ORCPT ); Wed, 29 Jan 2020 12:42:16 -0500 Received: by mail-io1-f48.google.com with SMTP id h8so693563iob.2 for ; Wed, 29 Jan 2020 09:42:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=c/PaCl2xkoxkKr7PKewuQH6ZMYi7SOFMEsRi72zCft0=; b=FBMHWlFOzfgHHMufrlWlQ5OKMv5jU/Ixh8niFQ+h4dsJZsQkjoUNVrL13drl8bWfaO E/lCeJACOih8MKPZyulPOrNnGkyUO53whet5U9rXMQFwlkGHfN5THnQScEuengxxsmoj M3BtOBe8FthslEczBe8zRC3UQ8qNcLFS6aXc+2mto9CKyeCssPjG+Uxt1WlVqg6z85Nq 0BMdMSsssH8/795J5N60hUTaq7jLilslH0VvKX/LMUHdDW188X9d5Ve/zFwfdrVEeQal yq8bv7eyysumkUGoyO/6cRq0LQx3ftHqh4ozXrLNPVPQ1u/kKGD+MIt68/8byu4uY3ch BKIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=c/PaCl2xkoxkKr7PKewuQH6ZMYi7SOFMEsRi72zCft0=; b=lIbPO1/L3yYXKo9m1ifgL0qybvAqWbEBgW4F9aCsIaizKwbz5rJ3exx35F14RJGAUy wo0PxD3MTtZyeAHC8vmci4SyqXzIIbGRn9zqD5qQ0lrO2aLdhFfqWp6D1Cr5ogW5exAf VjFta+4pwsrrgrdyYkfQ9iaazs3CCWUu0K2vFhFUOwwU3KI9RCGNfuLOGmnWe22+wDox vXU7mp1/aZVur4uI88sZyAA7Xdd0d3MHO7Q3MBCZSBGTID+07Wco9ObgP/6tI6S3s6Jw kSW48uL9g+vKqk5et5xAjNxyDS3pTkhYfzdlzgLF45idvFIO7/z6m/kwZl1gxmLdtLL2 NPIQ== X-Gm-Message-State: APjAAAUidBBZB46QkWw9pDdCrg6qDMFogUU0h3p0SjKJtkQHPa0MeJzD iCia6HWqbWIDdRGnTPFoFBvx+w== X-Google-Smtp-Source: APXvYqxQpQ96F2/ImIUt7I12UspEtfcQLo75Mnz2j/CGh8+0TRgNNmrkOceOg9/sDd7X4LY5z9IpNQ== X-Received: by 2002:a02:a694:: with SMTP id j20mr205499jam.69.1580319735479; Wed, 29 Jan 2020 09:42:15 -0800 (PST) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id s21sm687570ioa.33.2020.01.29.09.42.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2020 09:42:14 -0800 (PST) Subject: Re: IORING_REGISTER_CREDS[_UPDATE]() and credfd_create()? From: Jens Axboe To: Pavel Begunkov , Stefan Metzmacher Cc: io-uring , Linux API Mailing List References: <688e187a-75dd-89d9-921c-67de228605ce@samba.org> <1ac31828-e915-6180-cdb4-36685442ea75@kernel.dk> <0d4f43d8-a0c4-920b-5b8f-127c1c5a3fad@kernel.dk> <2d7e7fa2-e725-8beb-90b9-6476d48bdb33@gmail.com> <6c401e23-de7c-1fc1-4122-33d53fcf9700@kernel.dk> <35eebae7-76dd-52ee-58b2-4f9e85caee40@kernel.dk> <6e5ab6bf-6ff1-14df-1988-a80a7c6c9294@gmail.com> <2019e952-df2a-6b57-3571-73c525c5ba1a@kernel.dk> <0df4904f-780b-5d5f-8700-41df47a1b470@kernel.dk> <5406612e-299d-9d6e-96fc-c962eb93887f@gmail.com> <821243e7-b470-ad7a-c1a5-535bee58e76d@samba.org> <9a419bc5-4445-318d-87aa-1474b49266dd@gmail.com> <40d52623-5f9c-d804-cdeb-b7da6b13cb4f@samba.org> <3e1289de-8d8e-49cf-cc9f-fb7bc67f35d5@gmail.com> <9aef3b3b-7e71-f7f1-b366-2517b4d52719@kernel.dk> Message-ID: Date: Wed, 29 Jan 2020 10:42:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <9aef3b3b-7e71-f7f1-b366-2517b4d52719@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 1/29/20 10:34 AM, Jens Axboe wrote: > On 1/29/20 7:23 AM, Pavel Begunkov wrote: >>>>> The override_creds(personality_creds) has changed current->cred >>>>> and get_current_cred() will just pick it up as in the default case. >>>>> >>>>> This would make the patch much simpler and allows put_cred() to be >>>>> in io_put_work() instead of __io_req_aux_free() as explained above. >>>>> >>>> >>>> It's one extra get_current_cred(). I'd prefer to find another way to >>>> clean this up. >>> >>> As far as I can see it avoids a get_cred() in the IOSQE_PERSONALITY case >>> and the if (!req->work.creds) for both cases. >> >> Great, that you turned attention to that! override_creds() is already >> grabbing a ref, so it shouldn't call get_cred() there. >> So, that's a bug. > > It's not though - one is dropped in that function, the other when the > request is freed. So we do need two references to it. With the proposed > change to keep the override_creds() variable local for that spot we > don't, and the get_cred() can then go. > >> It could be I'm wrong with the statement above, need to recheck all this >> code to be sure. > > I think you are :-) > >> BTW, io_req_defer_prep() may be called twice for a req, so you will >> reassign it without putting a ref. It's safer to leave NULL checks. At >> least, until I've done reworking and fixing preparation paths. > > Agree, the NULL checks are safer and we should keep them. > > Going through the rest of this thread, I'm making the following changes: > > - ID must be > 0. I like that change, as we don't need an sqe flag to > select personality then, and it also makes it obvious that id == 0 is > just using current creds. > > - Fixed the missing put_cred() in the teardown > > - Use a local variable in io_submit_sqe() instead of assigning the > creds to req->work.creds there > > - Use cyclic idr allocation > > I'm going to fold in as appropriate. If there are fixes needed on top of > that, let's do them separately. In particular, would love a patch that only assigns req->work.creds if we do go async, so we can leave the put_cred() in io_put_work() instead of needing it in __io_req_aux_free(). -- Jens Axboe