From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F416C32771 for ; Sat, 18 Jan 2020 20:45:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3EBE224683 for ; Sat, 18 Jan 2020 20:45:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="fgqd9Gs3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727029AbgARUpQ (ORCPT ); Sat, 18 Jan 2020 15:45:16 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:34961 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726933AbgARUpP (ORCPT ); Sat, 18 Jan 2020 15:45:15 -0500 Received: by mail-pl1-f193.google.com with SMTP id g6so11384806plt.2 for ; Sat, 18 Jan 2020 12:45:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=cPDaiuuezvQHY5FbiMneb91VHbFptyeIrZbpDAf5ezI=; b=fgqd9Gs3tFFWeije8getX63o/kmBD21eAjCYfAYviID4Tuyxa57QscYlsxwphjMrTL 0cs8dBMtPWoQc5hIVzdwMwzH/QnfCn9vaI2jcVokoUFLHSiwJ4FAK5uDTH41On4NEKGR FfgWEcGWokyqh5HvVWh4WwIA1Cb+QLsByoRrczvqxfxC0rYToNlviLmDwuEdZraJHRm4 WStqUrzVZa2Sfc2FcapQBdm0khNTL9zOxM544iIMqGuKbcaU1jaqJR+NXxDgrArcgX0A r79hUg3t2xNlRTPBmkDbkilG9ZwG+fblXlCjVtnO9DtmX9jUk7YjrFi0SeBDfgiCk7BR KjSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cPDaiuuezvQHY5FbiMneb91VHbFptyeIrZbpDAf5ezI=; b=mgx8cJfW0UMF8ch6kGAUKNrRkl+OE8irdMELuqUVddfq3uMQU8vNdlDiL8euwawMYP rvvaLjnIJR/5wlgL9BDWkeaQyoscVq2hTfs0a1RADBpf2Jgzv2BgTrucUWkC1pxnxf5A Roo0nHBAxW0BMU/EXQhmdcZwbnfshYvLjN/gvn0SQx30GpY8WM7JuWwqx8krD8F15/4u HKFGiM1jaZm4peEGlXlOzqH70E0IopglxPBnPoIT6U4HW7+cKzFvxOoPzo7ZDbiKv4FP qtCzHe0kvpsMhRKhpDZVxBJ91kzIiUAg9DEDH/9pEXgqBno7haK6wAU9yl4wZy59Ag9Q UtsQ== X-Gm-Message-State: APjAAAWwf9MQp1wB60wwKshneCZ/YoIxXfdM7VkxgDJ3aeL7+krczkES 9fJqPiR0XaTT2b/4MR98TvzoUNyOo00= X-Google-Smtp-Source: APXvYqxdZFc8rUKvnYBdsfaCbtZU51j/0ksv614dOtS1iFCJC1LjBpRoRpa9DRX4lVO2NynxWQU7lA== X-Received: by 2002:a17:902:b701:: with SMTP id d1mr6647046pls.280.1579380315182; Sat, 18 Jan 2020 12:45:15 -0800 (PST) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id v15sm12050145pju.15.2020.01.18.12.45.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Jan 2020 12:45:14 -0800 (PST) Subject: Re: [PATCH v2] io_uring: optimise sqe-to-req flags translation To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: <06bcf64774c4730b33d1ef65e4fcb67f381cae08.1579340590.git.asml.silence@gmail.com> From: Jens Axboe Message-ID: Date: Sat, 18 Jan 2020 13:45:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 1/18/20 10:10 AM, Pavel Begunkov wrote: > On 18/01/2020 19:34, Jens Axboe wrote: >>> +enum { >>> + /* correspond one-to-one to IOSQE_IO_* flags*/ >>> + REQ_F_FIXED_FILE = BIT(REQ_F_FIXED_FILE_BIT), /* ctx owns file */ >> >> I'd put the comment on top of the line instead, these lines are way too >> long. > > I find it less readable, but let's see Well, the monster lines are unreadable on an 80-char display... I'm generally not a stickler with 80 chars, if a few over needs we don't need to break, I'm all for it. But the long comments are unreadable for me. -- Jens Axboe