From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7D8A2BE621 for ; Sun, 23 Nov 2025 22:52:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763938326; cv=none; b=RikqziGJWtdGan4XLXGoZrZhfTomyspN10WlQvyYymQ4mztt+fqiDsrzVKDO28oFEIDCrjIOS9yZOQBgX6/mODaTljZD3l9W93eg0jC9Utie/GZOjS/Eh8lEuWEk4YmtCX8kljcPaUpjAfLPopKxfKCnjWcLUnyGwIjXYtHgaB0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763938326; c=relaxed/simple; bh=3Yw5gnORHPUkwdVq0k9YaTZDeI1SsW0ivfxZGTZP3Cc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cJ2lChIAQqeFXD3sVA9qdMlMUKhaZPR30/uUv56aeJpm//S9KDq0V1W2qLTLvqNRJtieRKT4J/JcX7KmRnv7x0X7/uVl64i2PtuoUuYcn8yg8HSoyqwyZeOuo8l7O0zC1TOm/G9rnBNBOY4GA6vR4uCjgohk11eARY8D3yOEVyg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g7doDkH8; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g7doDkH8" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-42b3ac40ae4so2008374f8f.0 for ; Sun, 23 Nov 2025 14:52:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763938323; x=1764543123; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I7U8WjZVUJLujU3iF7ZJF1k1wei+IEPh96Vfasq7vRA=; b=g7doDkH8grU2riP18oRUs8e7YFeVqVJgtvrGYpXTDCrFt7l5LfFbbFQV7UU8gCdyGp MR6NYn3HA3mxPoK15qLVKYWUrVqa2sfDDOUxXfAGmwHbFMC18bSE8YvzGj5tDWtryPks 8UjKawvGHRUpM86YqWkTWDXnmohwApBm1LnKVh3jC1QLu2SO9zJQF3JDzKeLlqccltMn yxQ8bnOZ3aomzXJKG1yB8F/V0ziKDadgldKdoc8BkUl0YoTBEp6N1E1oUQC4rlfmCYD2 uEJYUbT5DBWpVja9JCdof68MIXMc9ZEXqxDvtxe2FrU50U4bMf6S5XVfC7o8b74QdMq6 LbeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763938323; x=1764543123; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=I7U8WjZVUJLujU3iF7ZJF1k1wei+IEPh96Vfasq7vRA=; b=GyClzYKLo9RwmHsRhFBERE1xrqVgVYoclcuQ9sjBgd3Ezq8eerZjZAOdJr/0wGlROr QO+NnJvun5QOK/InS1uPdfHJ+sKsMr3atMQ5x/38W6zMg6++oq4xIrE/QyaMxrswDLo0 l+lQArz8KM9AZtD9nFNdBDhvR9Cm8mBbcXmqEsBlGW+fHpFy82d5a5IYkQvoyZy2QLIi aO/CnhO2OeZ8WadFbdBnaL7GZn4Uy6x20CditT8Hce8me53f1nuJTgu9Es+S5Pvio2vw 10m8PE6tCXMutg9Xn0CibXL9kCzW7aSr6Cf5jHRJmumS3vC6hyqsrmnfSrGBvD/bgXE2 nPsg== X-Forwarded-Encrypted: i=1; AJvYcCVm/wUf+vedXc03poqabJwXZ9OFocjCGVA/rTbEcCdJBcyVC5NmrkHDOec38gaGDAvG+QjvHErkGg==@vger.kernel.org X-Gm-Message-State: AOJu0Yxs06bR8n0uKFfMKiJlp0+hGvOT08RUYOJcjM7SGenOT16dFsKL Ew/Aprdb1EYx6msk9viG3dxJU/V28z/1uCA0ciyNP329GL/lbqOD/aoZ X-Gm-Gg: ASbGncuPl4LzqxVDkDypYqBM06+BoHgDyPm5qedFBmXrkeMuQzVaDlAQz1TAF7/uhkp L+Qvk+uu5gY/qcKu9m1BgoBw6sTHJy1zznV5Uc5KGTHnW3xTGbomxf89Lfxf9/QBKV/kDRn+M5C DAY5NjEhg7oylP4Ky8/91tD8kJYlq+6MJjoXGPEN8TkiDiAsM4VgOXAXupaJe6/P9EuefNe2YVy nf0W8GHgktJ147dXh2CPt9jw6YIshNCpVsT+E7VniZEOFo/alvUf5lw7JzlXZI8VCWh4pibLQN1 wsYLVNb4o8VlmdC+ex0tOCU54juTGHLtUq2H8rUOAz9fMGsszg35qcSHMXWw9dzx/f/giBfFE8w HiH3TdpViDh5x6YH88lek+TCZoafySSUJepsAsw12oc64M4qbu8E5zI0e0PIIdFfTO/vTMIm9Qo 3xgrGXKHwv6m/Hzg== X-Google-Smtp-Source: AGHT+IHP6prALX51tQ6Iw6dY96wePGFkgrZhEc+sNQdx04+GPwBJksTSC7+04SaYBCnud+M1CKHhfg== X-Received: by 2002:a05:6000:430e:b0:42b:2e94:5a94 with SMTP id ffacd0b85a97d-42cc1cf4540mr9370759f8f.29.1763938323162; Sun, 23 Nov 2025 14:52:03 -0800 (PST) Received: from 127.mynet ([2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fb9190sm24849064f8f.33.2025.11.23.14.51.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Nov 2025 14:52:01 -0800 (PST) From: Pavel Begunkov To: linux-block@vger.kernel.org, io-uring@vger.kernel.org Cc: Vishal Verma , tushar.gohad@intel.com, Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Alexander Viro , Christian Brauner , Andrew Morton , Sumit Semwal , =?UTF-8?q?Christian=20K=C3=B6nig?= , Pavel Begunkov , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, David Wei Subject: [RFC v2 10/11] io_uring/rsrc: add dmabuf-backed buffer registeration Date: Sun, 23 Nov 2025 22:51:30 +0000 Message-ID: X-Mailer: git-send-email 2.52.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add an ability to register a dmabuf backed io_uring buffer. It also needs know which device to use for attachment, for that it takes target_fd and extracts the device through the new file op. Unlike normal buffers, it also retains the target file so that any imports from ineligible requests can be rejected in next patches. Suggested-by: Vishal Verma Suggested-by: David Wei Signed-off-by: Pavel Begunkov --- io_uring/rsrc.c | 106 +++++++++++++++++++++++++++++++++++++++++++++++- io_uring/rsrc.h | 1 + 2 files changed, 106 insertions(+), 1 deletion(-) diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c index 691f9645d04c..7dfebf459dd0 100644 --- a/io_uring/rsrc.c +++ b/io_uring/rsrc.c @@ -10,6 +10,8 @@ #include #include #include +#include +#include #include @@ -802,6 +804,106 @@ bool io_check_coalesce_buffer(struct page **page_array, int nr_pages, return true; } +struct io_regbuf_dma { + struct dma_token *token; + struct file *target_file; + struct dma_buf *dmabuf; +}; + +static void io_release_reg_dmabuf(void *priv) +{ + struct io_regbuf_dma *db = priv; + + dma_token_release(db->token); + dma_buf_put(db->dmabuf); + fput(db->target_file); + kfree(db); +} + +static struct io_rsrc_node *io_register_dmabuf(struct io_ring_ctx *ctx, + struct io_uring_reg_buffer *rb, + struct iovec *iov) +{ + struct dma_token_params params = {}; + struct io_rsrc_node *node = NULL; + struct io_mapped_ubuf *imu = NULL; + struct io_regbuf_dma *regbuf = NULL; + struct file *target_file = NULL; + struct dma_buf *dmabuf = NULL; + struct dma_token *token; + int ret; + + if (iov->iov_base || iov->iov_len) + return ERR_PTR(-EFAULT); + + node = io_rsrc_node_alloc(ctx, IORING_RSRC_BUFFER); + if (!node) { + ret = -ENOMEM; + goto err; + } + + imu = io_alloc_imu(ctx, 0); + if (!imu) { + ret = -ENOMEM; + goto err; + } + + regbuf = kzalloc(sizeof(*regbuf), GFP_KERNEL); + if (!regbuf) { + ret = -ENOMEM; + goto err; + } + + target_file = fget(rb->target_fd); + if (!target_file) { + ret = -EBADF; + goto err; + } + + dmabuf = dma_buf_get(rb->dmabuf_fd); + if (IS_ERR(dmabuf)) { + ret = PTR_ERR(dmabuf); + dmabuf = NULL; + goto err; + } + + params.dmabuf = dmabuf; + params.dir = DMA_BIDIRECTIONAL; + token = dma_token_create(target_file, ¶ms); + if (IS_ERR(token)) { + ret = PTR_ERR(token); + goto err; + } + + regbuf->target_file = target_file; + regbuf->token = token; + regbuf->dmabuf = dmabuf; + + imu->nr_bvecs = 1; + imu->ubuf = 0; + imu->len = dmabuf->size; + imu->folio_shift = 0; + imu->release = io_release_reg_dmabuf; + imu->priv = regbuf; + imu->flags = IO_IMU_F_DMA; + imu->dir = IO_IMU_DEST | IO_IMU_SOURCE; + refcount_set(&imu->refs, 1); + node->buf = imu; + return node; +err: + if (regbuf) + kfree(regbuf); + if (imu) + io_free_imu(ctx, imu); + if (node) + io_cache_free(&ctx->node_cache, node); + if (target_file) + fput(target_file); + if (dmabuf) + dma_buf_put(dmabuf); + return ERR_PTR(ret); +} + static struct io_rsrc_node *io_sqe_buffer_register(struct io_ring_ctx *ctx, struct io_uring_reg_buffer *rb, struct iovec *iov, @@ -817,7 +919,7 @@ static struct io_rsrc_node *io_sqe_buffer_register(struct io_ring_ctx *ctx, bool coalesced = false; if (rb->dmabuf_fd != -1 || rb->target_fd != -1) - return NULL; + return io_register_dmabuf(ctx, rb, iov); if (!iov->iov_base) return NULL; @@ -1117,6 +1219,8 @@ static int io_import_fixed(int ddir, struct iov_iter *iter, offset = buf_addr - imu->ubuf; + if (imu->flags & IO_IMU_F_DMA) + return -EOPNOTSUPP; if (imu->flags & IO_IMU_F_KBUF) return io_import_kbuf(ddir, iter, imu, len, offset); diff --git a/io_uring/rsrc.h b/io_uring/rsrc.h index 7c1128a856ec..280d3988abf3 100644 --- a/io_uring/rsrc.h +++ b/io_uring/rsrc.h @@ -30,6 +30,7 @@ enum { enum { IO_IMU_F_KBUF = 1, + IO_IMU_F_DMA = 2, }; struct io_mapped_ubuf { -- 2.52.0