From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
Anuj gupta <anuj1072538@gmail.com>
Cc: Anuj Gupta <anuj20.g@samsung.com>,
io-uring@vger.kernel.org, joshi.k@samsung.com
Subject: Re: [PATCH liburing] test/io_uring_passthrough: add test for vectored fixed-buffers
Date: Wed, 21 May 2025 08:14:19 -0600 [thread overview]
Message-ID: <b4f0d0ef-b05f-4f40-bace-e7632293fbb6@kernel.dk> (raw)
In-Reply-To: <48319c53-9556-4a97-97b3-3530247b6046@gmail.com>
On 5/21/25 8:05 AM, Pavel Begunkov wrote:
>> About the use of io_uring_prep_read/write*() helpers ? you're right,
>> they don?t really add much here since the passthrough command handles
>> the fields directly. I?ll work on a cleanup patch to remove those and
>> simplify the submission code.
>
> I don't care about the test itself much, but it means there
> are lots of unused fields for the nvme commands that are not
> checked by the kernel and hence can't be reused in the future.
> That's not great
It's still a pretty recent addition, no reason we can't add the checks
and get them back to stable as well. At least that would open the door
for more easy future expansion.
--
Jens Axboe
next prev parent reply other threads:[~2025-05-21 14:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250521083658epcas5p2c2d23dbcfac4242343365bb85301c5ea@epcas5p2.samsung.com>
2025-05-21 8:19 ` [PATCH liburing] test/io_uring_passthrough: add test for vectored fixed-buffers Anuj Gupta
2025-05-21 9:42 ` Pavel Begunkov
2025-05-21 10:35 ` Anuj gupta
2025-05-21 13:08 ` Jens Axboe
2025-05-21 14:20 ` Anuj gupta
2025-05-21 14:24 ` Jens Axboe
2025-05-21 14:05 ` Pavel Begunkov
2025-05-21 14:14 ` Jens Axboe [this message]
2025-05-21 14:46 ` Pavel Begunkov
2025-05-21 14:51 ` Jens Axboe
2025-05-21 13:08 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4f0d0ef-b05f-4f40-bace-e7632293fbb6@kernel.dk \
--to=axboe@kernel.dk \
--cc=anuj1072538@gmail.com \
--cc=anuj20.g@samsung.com \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=joshi.k@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox