From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49477C433FE for ; Tue, 8 Nov 2022 07:15:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232923AbiKHHPD (ORCPT ); Tue, 8 Nov 2022 02:15:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229731AbiKHHPC (ORCPT ); Tue, 8 Nov 2022 02:15:02 -0500 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3030712634; Mon, 7 Nov 2022 23:15:01 -0800 (PST) Received: from [10.7.7.5] (unknown [182.253.88.158]) by gnuweeb.org (Postfix) with ESMTPSA id 8868E804D1; Tue, 8 Nov 2022 07:14:58 +0000 (UTC) X-GW-Data: lPqxHiMPbJw1wb7CM9QUryAGzr0yq5atzVDdxTR0iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1667891700; bh=XCWz6ScmoIObKuRId785vIH8+G9yaE9O8IRbUT0edwM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tG0wKmr24hD/A6Kf5NjxnSW7rbmUBchYFUbCOPBd9KLArSbAwyPYRUvQraBT2Vck3 qCiLqe/0pPJrTsN0uF6LepmfHai4T9HbFAXp2y4ZZrJ3CIAT7vU24nsmhaMWilXgoe yqKR3vz9nlse7/umllcDwu5xqEsPyp6JhXMwj1HYADTj4ETak/D+A2rdpyNVx2FAvk Ys1XE299CZWOJufcTW6ZEk6H5eAWo7fMicmOVRKWJcE0rBErqgLSeZO3RBQ/F6bFxC eujTl9vDch31McNdq2uCpX9oxR7RjCC/mAtPnjVbWt97KKZEZHIPF6GVRWJVM/DD5J kqbg4aNIwMn+Q== Message-ID: Date: Tue, 8 Nov 2022 14:14:56 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [RFC PATCH v2 1/4] liburing: add api to set napi busy poll timeout Content-Language: en-US To: Stefan Roesch , Facebook Kernel Team Cc: Jens Axboe , Olivier Langlois , netdev Mailing List , io-uring Mailing List , Jakub Kicinski References: <20221107175357.2733763-1-shr@devkernel.io> <20221107175357.2733763-2-shr@devkernel.io> From: Ammar Faizi In-Reply-To: <20221107175357.2733763-2-shr@devkernel.io> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 11/8/22 12:53 AM, Stefan Roesch wrote: > diff --git a/src/liburing.map b/src/liburing.map > index 06c64f8..793766e 100644 > --- a/src/liburing.map > +++ b/src/liburing.map > @@ -60,6 +60,8 @@ LIBURING_2.3 { > global: > io_uring_register_sync_cancel; > io_uring_register_file_alloc_range; > + io_uring_register_busy_poll_timeout; > + io_uring_unregister_busy_poll_timeout; > io_uring_enter; > io_uring_enter2; > io_uring_setup; > @@ -67,3 +69,9 @@ LIBURING_2.3 { > io_uring_get_events; > io_uring_submit_and_get_events; > } LIBURING_2.2; I don't understand this part. You add: io_uring_register_busy_poll_timeout io_uring_unregister_busy_poll_timeout in the LIBURING_2.3 section. What are they? I don't find their declaration and definition. How do they differ from: io_uring_napi_register_busy_poll_timeout io_uring_napi_unregister_busy_poll_timeout that you add in the LIBURING_2.4 section? -- Ammar Faizi