From: Pavel Begunkov <[email protected]>
To: Jens Axboe <[email protected]>, Chenliang Li <[email protected]>
Cc: [email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected]
Subject: Re: [PATCH liburing v3] test: add test cases for hugepage registered buffers
Date: Fri, 2 Aug 2024 11:47:30 +0100 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 8/1/24 21:51, Jens Axboe wrote:
> On 7/31/24 7:01 PM, Chenliang Li wrote:
>> On Thu, 1 Aug 2024 00:13:10 +0100, Pavel Begunkov wrote:
>>> On 5/31/24 06:20, Chenliang Li wrote:
>>>> Add a test file for hugepage registered buffers, to make sure the
>>>> fixed buffer coalescing feature works safe and soundly.
>>>>
>>>> Testcases include read/write with single/multiple/unaligned/non-2MB
>>>> hugepage fixed buffers, and also a should-not coalesce case where
>>>> buffer is a mixture of different size'd pages.
>>>
>>> lgtm, would be even better if you can add another patch
>>> testing adding a small buffer on the left size of a hugepage,
>>> i.e. like mmap_mixutre() but the small buffer is on the other
>>> side.
>>
>> Sure, will add that.
>
> I'll queue up this v3, but please do send that as an incremental
> patch as I agree it's a good addition
I have to add that tests are already well made, the kernel code
is not symmetric however, so it'd give us more confidence and
help to not regress in the future.
--
Pavel Begunkov
next prev parent reply other threads:[~2024-08-02 10:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240531052031epcas5p3730deb2a19b401e1f772be633b4c6288@epcas5p3.samsung.com>
2024-05-31 5:20 ` [PATCH liburing v3] test: add test cases for hugepage registered buffers Chenliang Li
2024-07-31 23:13 ` Pavel Begunkov
[not found] ` <CGME20240801010122epcas5p3ea76168da6d5dd9ba6d8fe54537591d8@epcas5p3.samsung.com>
2024-08-01 1:01 ` Chenliang Li
2024-08-01 20:51 ` Jens Axboe
2024-08-02 10:47 ` Pavel Begunkov [this message]
2024-08-02 13:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox