public inbox for [email protected]
 help / color / mirror / Atom feed
From: Pavel Begunkov <[email protected]>
To: Jens Axboe <[email protected]>, [email protected]
Subject: Re: [PATCH 0/3] task/files cancellation fixes
Date: Sun, 20 Dec 2020 18:01:20 +0000	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 20/12/2020 13:21, Pavel Begunkov wrote:
> First two are only for task cancellation, the last one for both.
> 
> Jens, do you remember the exact reason why you added the check
> removed in [3/3]? I have a clue, but that stuff doesn't look
> right regardless. See "exit: do exit_task_work() before shooting
> off mm" thread.

The question is answered, the bug is still here, but that's too
early for 3/3. Please consider first 2 patches.

> 
> Pavel Begunkov (3):
>   io_uring: always progress task_work on task cancel
>   io_uring: end waiting before task cancel attempts
>   io_uring: fix cancellation hangs
> 
>  fs/io_uring.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 

-- 
Pavel Begunkov

  parent reply	other threads:[~2020-12-20 18:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-20 13:21 [PATCH 0/3] task/files cancellation fixes Pavel Begunkov
2020-12-20 13:21 ` [PATCH 1/3] io_uring: always progress task_work on task cancel Pavel Begunkov
2020-12-20 13:21 ` [PATCH 2/3] io_uring: end waiting before task cancel attempts Pavel Begunkov
2020-12-20 13:21 ` [PATCH 3/3] io_uring: fix cancellation hangs Pavel Begunkov
2020-12-20 18:01 ` Pavel Begunkov [this message]
2020-12-20 18:05   ` [PATCH 0/3] task/files cancellation fixes Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox