From: Jens Axboe <[email protected]>
To: Dylan Yudaken <[email protected]>, [email protected]
Cc: [email protected]
Subject: Re: [PATCH 2/2] io_uring: do not clamp read length for multishot read
Date: Mon, 6 Nov 2023 07:46:20 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 11/5/23 3:30 PM, Dylan Yudaken wrote:
> When doing a multishot read, the code path reuses the old read
> paths. However this breaks an assumption built into those paths,
> namely that struct io_rw::len is available for reuse by __io_import_iovec.
>
> For multishot this results in len being set for the first receive
> call, and then subsequent calls are clamped to that buffer length incorrectly.
Should we just reset this to 0 always in io_read_mshot()? And preferably
with a comment added as well as to why that is necessary to avoid
repeated clamping.
--
Jens Axboe
next prev parent reply other threads:[~2023-11-06 14:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-05 22:30 [PATCH 0/2] io_uring: mshot read fix for buffer size changes Dylan Yudaken
2023-11-05 22:30 ` [PATCH 1/2] io_uring: do not allow multishot read to set addr or len Dylan Yudaken
2023-11-06 14:32 ` Jens Axboe
2023-11-06 14:51 ` Jens Axboe
2023-11-06 15:31 ` Dylan Yudaken
2023-11-05 22:30 ` [PATCH 2/2] io_uring: do not clamp read length for multishot read Dylan Yudaken
2023-11-06 14:46 ` Jens Axboe [this message]
2023-11-06 15:33 ` Dylan Yudaken
2023-11-06 15:46 ` Jens Axboe
2023-11-06 17:56 ` Jens Axboe
2023-11-06 20:35 ` [PATCH 0/2] io_uring: mshot read fix for buffer size changes Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox