Re: [PATCH liburing v2 2/4] test/bind-listen.t: Use ephemeral port

[Jens Axboe <axboe@kernel.dk>]

On 12/2/25 4:37 PM, Gabriel Krisman Bertazi wrote:
> Jens Axboe <axboe@kernel.dk> writes:
> 
>> On 11/25/25 2:27 PM, Gabriel Krisman Bertazi wrote:
>>> This test fails if port 8000 is already in use by something else.  Now
>>> that we have getsockname with direct file descriptors, use an ephemeral
>>> port instead.
>>
>> How is this going to work on older kernels? Probably retain the old
>> behavior, even if kind of shitty, on old kernels. Otherwise anything
>> pre 6.19 will now not run the bind-listen test at all.
> 
> Do you have a suggestion on how to check getsockname without doing the
> whole socket setup just to probe, considering this is a uring_cmd?
> Perhaps checking a feature that was merged at the same time?

I think just retain the old code - do the getsockname via io_uring, and
if it fails, then fall back to the old code. Then it'll both exercise
the new code, when available, yet still work on older kernels still.

-- 
Jens Axboe