From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Cc: [email protected], Joakim Hassila <[email protected]>
Subject: Re: [PATCH] io_uring: fix early sqd_list removal sqpoll hangs
Date: Wed, 14 Apr 2021 10:19:27 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <1592cc2b0418a0512c83898dbef0b1c9722e8645.1618310545.git.asml.silence@gmail.com>
On 4/13/21 4:43 AM, Pavel Begunkov wrote:
> [ 245.463317] INFO: task iou-sqp-1374:1377 blocked for more than 122 seconds.
> [ 245.463334] task:iou-sqp-1374 state:D flags:0x00004000
> [ 245.463345] Call Trace:
> [ 245.463352] __schedule+0x36b/0x950
> [ 245.463376] schedule+0x68/0xe0
> [ 245.463385] __io_uring_cancel+0xfb/0x1a0
> [ 245.463407] do_exit+0xc0/0xb40
> [ 245.463423] io_sq_thread+0x49b/0x710
> [ 245.463445] ret_from_fork+0x22/0x30
>
> It happens when sqpoll forgot to run park_task_work and goes to exit,
> then exiting user may remove ctx from sqd_list, and so corresponding
> io_sq_thread() -> io_uring_cancel_sqpoll() won't be executed. Hopefully
> it just stucks in do_exit() in this case.
Added for 5.12, thanks.
--
Jens Axboe
prev parent reply other threads:[~2021-04-14 16:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 10:43 [PATCH] io_uring: fix early sqd_list removal sqpoll hangs Pavel Begunkov
2021-04-14 10:46 ` Pavel Begunkov
2021-04-14 16:19 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox