From: Pavel Begunkov <[email protected]>
To: Jens Axboe <[email protected]>,
[email protected], [email protected]
Subject: [PATCH 1/1] io-wq: close cancel gap for hashed linked work
Date: Sun, 22 Mar 2020 19:14:26 +0300 [thread overview]
Message-ID: <b9bc821a0ff3bc52a60281d8a9005dff93f6dcc3.1584893591.git.asml.silence@gmail.com> (raw)
After io_assign_current_work() of a linked work, it can be decided to
offloaded to another thread so doing io_wqe_enqueue(). However, until
next io_assign_current_work() it can be cancelled, that isn't handled.
Don't assign it, if it's not going to be executed.
Signed-off-by: Pavel Begunkov <[email protected]>
---
fs/io-wq.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/fs/io-wq.c b/fs/io-wq.c
index 9541df2729de..b3fb61ec0870 100644
--- a/fs/io-wq.c
+++ b/fs/io-wq.c
@@ -485,7 +485,7 @@ static void io_worker_handle_work(struct io_worker *worker)
struct io_wq *wq = wqe->wq;
do {
- struct io_wq_work *work;
+ struct io_wq_work *work, *assign_work;
unsigned int hash;
get_next:
/*
@@ -522,10 +522,14 @@ static void io_worker_handle_work(struct io_worker *worker)
hash = io_get_work_hash(work);
work->func(&work);
work = (old_work == work) ? NULL : work;
- io_assign_current_work(worker, work);
+
+ assign_work = work;
+ if (work && io_wq_is_hashed(work))
+ assign_work = NULL;
+ io_assign_current_work(worker, assign_work);
wq->free_work(old_work);
- if (work && io_wq_is_hashed(work)) {
+ if (work && !assign_work) {
io_wqe_enqueue(wqe, work);
work = NULL;
}
--
2.24.0
next reply other threads:[~2020-03-22 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 16:14 Pavel Begunkov [this message]
2020-03-22 17:04 ` [PATCH 1/1] io-wq: close cancel gap for hashed linked work Jens Axboe
2020-03-22 17:31 ` Pavel Begunkov
2020-03-22 17:33 ` [PATCH v2] " Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9bc821a0ff3bc52a60281d8a9005dff93f6dcc3.1584893591.git.asml.silence@gmail.com \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox