From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62BB1C636D7 for ; Fri, 17 Feb 2023 02:59:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229940AbjBQC7m (ORCPT ); Thu, 16 Feb 2023 21:59:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbjBQC7l (ORCPT ); Thu, 16 Feb 2023 21:59:41 -0500 Received: from cmx-mtlrgo002.bell.net (mta-mtl-003.bell.net [209.71.208.13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 266E452CD5; Thu, 16 Feb 2023 18:59:40 -0800 (PST) X-RG-CM-BuS: 0 X-RG-CM-SC: 0 X-RG-CM: Clean X-Originating-IP: [174.88.80.151] X-RG-Env-Sender: dave.anglin@bell.net X-RG-Rigid: 63E35FA800E69696 X-CM-Envelope: MS4xfDS1M4A5HPZRrAVRQyB2iOohsH4Dj6RVeGB41ueaCgO1Fk/A9LjemaXAXmynFLij5NHewWjLxHk6rbb3qIZiaMdeoybUTFcGK/3vHiREsCwxaSwZrIT7 WgQx+qI99yTgXdXg0+0YxRJB2Odt/h2ZQ5gP/PzqM1F8H50mGTCG0zsHN4vTEUV55rttLUdNuiG1IW0nGJnnvaOWXGlo/g+lAKpy7qneM035Wy2Dyh0M0Wsg of55edgOugYLt8S4Qc285C3rLC4soM+03aXWSCefL0CS2JDOokVUAQKUg+RDug/PGrSX0lMpVuq8JEedZ5jAXsg4H9SX3lLwaCJ+WViYgds= X-CM-Analysis: v=2.4 cv=GcB0ISbL c=1 sm=1 tr=0 ts=63eeed9a a=6Iw0JHgwQEnu+SgMJEJdFQ==:117 a=6Iw0JHgwQEnu+SgMJEJdFQ==:17 a=IkcTkHD0fZMA:10 a=FBHGMhGWAAAA:8 a=zyJUVnFRyeD255z3KfEA:9 a=QEXdDO2ut3YA:10 a=9gvnlMMaQFpL9xblJ6ne:22 Received: from [192.168.2.49] (174.88.80.151) by cmx-mtlrgo002.bell.net (5.8.814) (authenticated as dave.anglin@bell.net) id 63E35FA800E69696; Thu, 16 Feb 2023 21:59:38 -0500 Message-ID: Date: Thu, 16 Feb 2023 21:59:38 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: liburing test results on hppa Content-Language: en-US To: Jens Axboe , linux-parisc Cc: io-uring@vger.kernel.org, Helge Deller References: <64ff4872-cc6f-1e6a-46e5-573c7e64e4c9@bell.net> <6eddaf2b-991f-f848-4832-7005eccdeffa@kernel.dk> From: John David Anglin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 2023-02-16 9:33 p.m., Jens Axboe wrote: > On 2/16/23 4:32 PM, Jens Axboe wrote: >> On 2/16/23 4:26?PM, John David Anglin wrote: >>> On 2023-02-16 6:12 p.m., Jens Axboe wrote: >>>> On 2/16/23 4:00?PM, John David Anglin wrote: >>>>> Running test buf-ring.t bad run 0/0 = -233 >>>>> test_running(1) failed >>>>> Test buf-ring.t failed with ret 1 >>>> As mentioned previously, this one and the other -233 I suspect are due >>>> to the same coloring issue as was fixed by Helge's patch for the ring >>>> mmaps, as the provided buffer rings work kinda the same way. The >>>> application allocates some aligned memory, and registers it and the >>>> kernel then maps it. >>>> >>>> I wonder if these would work properly if the address was aligned to >>>> 0x400000? Should be easy to verify, just modify the alignment for the >>>> posix_memalign() calls in test/buf-ring.c. >>> Doesn't help. Same error. Can you point to where the kernel maps it? >> Yep, it goes io_uring.c:io_uring_register() -> >> kbuf.c:io_register_pbuf_ring() -> rsrc.c:io_pin_pages() which ultimately >> calls pin_user_pages() to map the memory. > Followup - a few of the provided buffer ring cases failed to properly > initialize the ring, poll-mshot-race was one of them... I've pushed out > fixes for this. Not sure if it fixes your particular issue, but worth > giving it another run. Results are still the same: Running test file-verify.t Found 163840, wanted 688128 Buffered novec reg test failed Test file-verify.t failed with ret 1 Tests timed out (2): Tests failed (4): poll-mshot-race still causes HPMC. -- John David Anglin dave.anglin@bell.net