[PATCH 1/1] io_uring/zcrx: fix pp destruction warnings

[PATCH 1/1] io_uring/zcrx: fix pp destruction warnings

[Pavel Begunkov]

With multiple page pools and in some other cases we can have allocated
niovs on page pool destruction. Remove a misplaced warning checking that
all niovs are returned to zcrx on io_pp_zc_destroy(). It was reported
before but apparently got lost.

Reported-by: Pedro Tammela <pctammela@mojatatu.com>
Fixes: 34a3e60821ab9 ("io_uring/zcrx: implement zerocopy receive pp memory provider")
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
 io_uring/zcrx.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/io_uring/zcrx.c b/io_uring/zcrx.c
index ade4da9c4e31..67c518d22e0c 100644
--- a/io_uring/zcrx.c
+++ b/io_uring/zcrx.c
@@ -862,10 +862,7 @@ static int io_pp_zc_init(struct page_pool *pp)
 static void io_pp_zc_destroy(struct page_pool *pp)
 {
 	struct io_zcrx_ifq *ifq = io_pp_to_ifq(pp);
-	struct io_zcrx_area *area = ifq->area;
 
-	if (WARN_ON_ONCE(area->free_count != area->nia.num_niovs))
-		return;
 	percpu_ref_put(&ifq->ctx->refs);
 }
 
-- 
2.49.0

Re: [PATCH 1/1] io_uring/zcrx: fix pp destruction warnings

[Jens Axboe]

On Mon, 07 Jul 2025 09:52:33 +0100, Pavel Begunkov wrote:
> With multiple page pools and in some other cases we can have allocated
> niovs on page pool destruction. Remove a misplaced warning checking that
> all niovs are returned to zcrx on io_pp_zc_destroy(). It was reported
> before but apparently got lost.
> 
> 

Applied, thanks!

[1/1] io_uring/zcrx: fix pp destruction warnings
      commit: 203817de269539c062724d97dfa5af3cdf77a3ec

Best regards,
-- 
Jens Axboe