From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E130C48BDF for ; Sun, 20 Jun 2021 22:17:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 723146113E for ; Sun, 20 Jun 2021 22:17:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229877AbhFTWTZ (ORCPT ); Sun, 20 Jun 2021 18:19:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229708AbhFTWTZ (ORCPT ); Sun, 20 Jun 2021 18:19:25 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 190EEC061574; Sun, 20 Jun 2021 15:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To: Subject:Sender:Reply-To:Cc:Content-ID:Content-Description; bh=PxeyDOaC5gOG9k7sFphHJqiDSQ/o/65kXWRJvbDb3GE=; b=K3/nXmL8a42OqCpuwQLk9igqqs 8SDKEfm9iyBqUqCZTXaqhtCmtrLJewE9ZmATsYaKhXX+t2bwB9nNRhuc84LwB8zleq3XOT/kzCCMI WPaYhfh3FxBX0i8CZ3EW66xe7+F3FCWcmE9sKleP0ICL9tB2nVhvHzHudV/5JhKswPUIUCmc0R569 93IpmHlRpTY4ceMNb9GQz2uLFvzkqzu7keNgLcPO98BQvbL6pVLHiNKlG/q1F6yBWwimyWyieqz+y rmZ/t0EGv0KZuPPcsavor6YtzOgP4Hpdvdj6rOFQMu40FwwGZ0fwJ/2gTyfeWh6nlvOZOLeWZpgxu kOtFXWVw==; Received: from [2601:1c0:6280:3f0::aefb] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lv5kd-001ftT-53; Sun, 20 Jun 2021 22:17:11 +0000 Subject: Re: [PATCH v2] io_uring: reduce latency by reissueing the operation To: Pavel Begunkov , Olivier Langlois , Jens Axboe , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: <4578f817-c920-85f1-91af-923d792fc912@infradead.org> <7ad30cb0-3322-6c40-2a1b-27308aa757d8@gmail.com> From: Randy Dunlap Message-ID: Date: Sun, 20 Jun 2021 15:17:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <7ad30cb0-3322-6c40-2a1b-27308aa757d8@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 6/20/21 1:08 PM, Pavel Begunkov wrote: > On 6/20/21 9:01 PM, Randy Dunlap wrote: >> On 6/20/21 12:28 PM, Olivier Langlois wrote: >>> On Sun, 2021-06-20 at 12:07 -0700, Randy Dunlap wrote: >>>> On 6/20/21 12:05 PM, Olivier Langlois wrote: >>>>> -               return false; >>>>> +               return ret?IO_ARM_POLL_READY:IO_ARM_POLL_ERR; >>>> >>>> Hi, >>>> Please make that return expression more readable. >>>> >>>> >>> How exactly? >>> >>> by adding spaces? >>> Changing the define names?? >> >> Adding spaces would be sufficient IMO (like Pavel suggested also). > > Agree. That should be in the code style somewhere > It is. -- ~Randy