From: Pavel Begunkov <[email protected]>
To: Colin King <[email protected]>,
Jens Axboe <[email protected]>,
[email protected]
Cc: [email protected], [email protected]
Subject: Re: [PATCH][next] io_uring: fix incorrect check for kvmalloc failure
Date: Mon, 26 Apr 2021 11:04:56 +0100 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 4/26/21 10:37 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Currently imu is being allocated but the kvmalloc failure is checking
> imu->bvec instead of imu. Fix this by checking imu for null.
Right, that's buggy.
fwiw, was reported by lkp and I sent a fix yesterday, so take any.
https://lore.kernel.org/io-uring/d28eb1bc4384284f69dbce35b9f70c115ff6176f.1619392565.git.asml.silence@gmail.com/T/#u
>
> Addresses-Coverity: ("Array compared against 0")
> Fixes: 41edf1a5ec96 ("io_uring: keep table of pointers to ubufs")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> fs/io_uring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 57a64c7e0e69..f4ec092c23f4 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -8269,7 +8269,7 @@ static int io_sqe_buffer_register(struct io_ring_ctx *ctx, struct iovec *iov,
> goto done;
>
> imu = kvmalloc(struct_size(imu, bvec, nr_pages), GFP_KERNEL);
> - if (!imu->bvec)
> + if (!imu)
> goto done;
>
> ret = 0;
>
--
Pavel Begunkov
prev parent reply other threads:[~2021-04-26 10:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 9:37 [PATCH][next] io_uring: fix incorrect check for kvmalloc failure Colin King
2021-04-26 10:04 ` Pavel Begunkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox