From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09183C43334 for ; Thu, 16 Jun 2022 15:58:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377602AbiFPP6T (ORCPT ); Thu, 16 Jun 2022 11:58:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377289AbiFPP6S (ORCPT ); Thu, 16 Jun 2022 11:58:18 -0400 Received: from out1.migadu.com (out1.migadu.com [IPv6:2001:41d0:2:863f::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 565131E3F2 for ; Thu, 16 Jun 2022 08:58:17 -0700 (PDT) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1655395095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1/Smaj4k5p9InvEfB/nqTCwK2f0CFeDnykN5aRYSINc=; b=XthrnsHK7veJKvcHikAAXrY6Fx/q4n92/QkP22p0sfMgj8R8KVBMNsteJTSp7+9KVxjlnn 1i5q83IID65XTF4HWXXXl84XSHkLN8ciqLdHunQIvPdG7RD7tuVb80916z+nAy4vEuwGDf YHaalSIrHmlF97FNGtc0csJoBORWluo= Date: Thu, 16 Jun 2022 23:58:08 +0800 MIME-Version: 1.0 Subject: Re: [PATCH for-next v3 00/16] 5.20 cleanups and poll optimisations Content-Language: en-US To: Pavel Begunkov , io-uring@vger.kernel.org Cc: Jens Axboe References: X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Hao Xu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 6/16/22 17:21, Pavel Begunkov wrote: > 1-4 kills REQ_F_COMPLETE_INLINE as we're out of bits. > > Patch 5 from Hao should remove some overhead from poll requests > > Patch 6 from Hao adds per-bucket spinlocks, and 16-19 do a little > bit of cleanup. The downside of per-bucket spinlocks is that it adds > additional spinlock/unlock pair in the poll request completion side, > which shouldn't matter much with 20/25. > > Patch 11 uses inline completion infra for poll requests, this nicely > improves perf when there is a good tw batching. > > Patch 12 implements the userspace visible side of > IORING_SETUP_SINGLE_ISSUER, it'll be used for poll requests and > later for spinlock optimisations. > > 13-16 introduces ->uring_lock protected cancellation hashing. It > requires us to grab ->uring_lock in the completion side, but saves > two spin lock/unlock pairs. We apply it automatically in cases the > mutex is already likely to be held (see 25/25 description), so there > is no additional mutex overhead and potential latency problemes. > Reviewed-by: Hao Xu