From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12757C43467 for ; Wed, 14 Oct 2020 09:20:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B726F20B1F for ; Wed, 14 Oct 2020 09:20:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="DNZ/9V7z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731112AbgJNJU5 (ORCPT ); Wed, 14 Oct 2020 05:20:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731058AbgJNJUn (ORCPT ); Wed, 14 Oct 2020 05:20:43 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 441BDC08EC6A for ; Tue, 13 Oct 2020 16:54:55 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id p3so360993pjd.0 for ; Tue, 13 Oct 2020 16:54:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OoUJ7lX2R2U0c2LHktECeAhkCF1e5wdtf2xgBEgdwtw=; b=DNZ/9V7zjzzagTKx2A67mUvfnjhrS37F0MEsqUwC5Vdim2aFAL+3kCokjEwz/BhKbz zH5wPTY3bDJ+VXiRiGm5KdLhafUnlbXGhZ3S0WLKpLRV5ARq9hGIbQpVK7CNJBQB0oho DJAJ5YBkaNDmkv1clj+abfmz+ceiIjQLiRBUUuKHQ/+telPHiJ/rj3LtqP8Qo/LipAGx pa0ezECnTrg4jlVs27wqJ1ZclY4TEBtxanSMG+hMD7jCeSz1tsAqUWgvYOf5egkQwqMq qnHEKYX9fUyUH+yVGvt5AAmPa1/+pgxrWP2jmZ13FIvwGHsn2NchGfjIGhyCZNJ4BjR1 J64w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OoUJ7lX2R2U0c2LHktECeAhkCF1e5wdtf2xgBEgdwtw=; b=SxHkjyt4ZEkThf2Xw3kH0JYzRCfw8YT+1Gx51xTbOubi+124hiExvtuJyMzDoFvWNH QxSaVoOSEf28hd0URGdLEl01nNiP7O5nYOo+w/YUDvIAcNwclk3b2n7w6zgbnhV/3UXE +OLcVEjzLpmbbt/95uXlVJT8fmP3Kij8VA6D6xcw7T1NZZ044fwiIHb5R1mGN/lMVoqc G+0r/CbHZ4R5WFKD2+Cf3Ezw+Njo2Ue9S6F3XXlYGiXo6/F8coi6nsyHZdnZn4nirMeZ CjBjZZ642h1Vc5GcAnlrxQoISk1GLe/dP5VJUxdxB68Ue3AEibpi8INbEVbcVSXQIuWD 9MsQ== X-Gm-Message-State: AOAM53027rozw+rxtxXZceSk3Z2TaXu1b3a8IDAMqyfVMUxxPNn3zSGS 9GJPzCMgTG02VtgfB7bqb/ChPQ== X-Google-Smtp-Source: ABdhPJws+u5VscfkfvF+d9f/ewTOW4jptZRkhRaXc1AF9uDwkxAqMc9t1EPXpRGrYy0WXKz35/n92Q== X-Received: by 2002:a17:90a:e00f:: with SMTP id u15mr791287pjy.87.1602633294801; Tue, 13 Oct 2020 16:54:54 -0700 (PDT) Received: from [192.168.1.134] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id g4sm844641pgj.15.2020.10.13.16.54.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Oct 2020 16:54:54 -0700 (PDT) Subject: Re: [PATCH 3/4] kernel: add support for TIF_NOTIFY_SIGNAL To: Thomas Gleixner , Oleg Nesterov Cc: linux-kernel@vger.kernel.org, io-uring@vger.kernel.org, peterz@infradead.org References: <20201008152752.218889-1-axboe@kernel.dk> <20201008152752.218889-4-axboe@kernel.dk> <20201009144328.GB14523@redhat.com> <875z7dd70p.fsf@nanos.tec.linutronix.de> From: Jens Axboe Message-ID: Date: Tue, 13 Oct 2020 17:54:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <875z7dd70p.fsf@nanos.tec.linutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 10/13/20 5:45 PM, Thomas Gleixner wrote: > On Fri, Oct 09 2020 at 09:13, Jens Axboe wrote: >>> Hmm. I just noticed that only x86 uses arch_do_signal(), so perhaps you can >>> add this change to this patch right now? Up to you. >> >> Sure, we can do that. Incremental on top then looks like the below. I don't >> feel that strongly about it, but it is nice to avoid re-testing the >> flags. > > Yes it makes sense. Can you please make the signature change of > arch_do_signal() in a preparatory patch and only make use of it when you > add the TIF bit to x86? Ala: https://git.kernel.dk/cgit/linux-block/commit/?h=tif-task_work&id=6a150da501727f6bdca4786a02c0a57160e13079 with the pre generic patch being: https://git.kernel.dk/cgit/linux-block/commit/?h=tif-task_work&id=add2e252ae8481350239c3cb893aed490c05c397 -- Jens Axboe