From: Jens Axboe <[email protected]>
To: Stefano Garzarella <[email protected]>
Cc: io-uring <[email protected]>
Subject: Re: [PATCH] io_uring: ensure open/openat2 name is cleaned on cancelation
Date: Fri, 25 Sep 2020 07:43:12 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <20200925083210.xwfmssdvg4t6j3ar@steredhat>
On 9/25/20 2:32 AM, Stefano Garzarella wrote:
> On Thu, Sep 24, 2020 at 02:59:33PM -0600, Jens Axboe wrote:
>> io_uring: ensure open/openat2 name is cleaned on cancelation
>>
>> If we cancel these requests, we'll leak the memory associated with the
>> filename. Add them to the table of ops that need cleaning, if
>> REQ_F_NEED_CLEANUP is set.
>>
>
> IIUC we inadvertently removed 'putname(req->open.filename)' from the cleanup
> function in commit e62753e4e292 ("io_uring: call statx directly").
>
> Should we add the Fixes tag?
>
> Fixes: e62753e4e292 ("io_uring: call statx directly")
You are right, I got a bit tricked by it since that commit removed
the putname(), and then later on we got rid of the (now) empty
openat/openat2 entries.
I'll add the fixes, which means it's 5.8 only.
> Reviewed-by: Stefano Garzarella <[email protected]>
Added, thanks for reviewing!
--
Jens Axboe
prev parent reply other threads:[~2020-09-25 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 20:59 [PATCH] io_uring: ensure open/openat2 name is cleaned on cancelation Jens Axboe
2020-09-25 8:32 ` Stefano Garzarella
2020-09-25 13:43 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox