From: Jens Axboe <[email protected]>
To: Lukas Czerner <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH 2/2] runtests: add ability to exclude tests
Date: Tue, 8 Sep 2020 08:10:31 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <20200908081400.pytf6abmvp7ke7my@work>
On 9/8/20 2:14 AM, Lukas Czerner wrote:
> On Mon, Sep 07, 2020 at 01:34:38PM -0600, Jens Axboe wrote:
>> On 9/7/20 7:22 AM, Lukas Czerner wrote:
>>> Signed-off-by: Lukas Czerner <[email protected]>
>>
>> This patch really needs some justification. I generally try to make sure
>> that older kernel skip tests appropriately, sometimes I miss some and I
>> fix them up when I find them.
>>
>> So just curious what the use case is here for skipping tests? Not
>> adverse to doing it, just want to make sure it's for the right reasons.
>
> I think this is very useful, at least for me, in situation where some
> tests are causeing problems (like hangs, panics) that are not fixed yet,
> but I would still like to run entire tests suite to make sure my changes
> in didn't break anything else. I find it especially usefull in rapidly
> evolving project like this.
Yeah agree, that can be useful.
> I have a V2 patches with that justification in place and some minor
> changes. I'll be sending that (hopefuly it won't take hours this time).
OK thanks, I'll take a look and get it applied if it looks good.
--
Jens Axboe
prev parent reply other threads:[~2020-09-08 14:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 13:22 [PATCH 1/2] runtests: Small code cleanup Lukas Czerner
2020-09-07 13:22 ` [PATCH 2/2] runtests: add ability to exclude tests Lukas Czerner
2020-09-07 16:21 ` Jens Axboe
2020-09-07 17:13 ` Lukas Czerner
2020-09-07 19:33 ` Jens Axboe
2020-09-07 19:34 ` Jens Axboe
2020-09-08 8:14 ` Lukas Czerner
2020-09-08 14:10 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox