From: Pavel Begunkov <[email protected]>
To: Jens Axboe <[email protected]>, Kanchan Joshi <[email protected]>
Cc: io-uring <[email protected]>, Kanchan Joshi <[email protected]>
Subject: Re: [PATCH] io_uring/uring_cmd: push IRQ based completions through task_work
Date: Mon, 27 Mar 2023 12:16:47 +0100 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 3/20/23 20:42, Jens Axboe wrote:
> On 3/20/23 2:03?PM, Jens Axboe wrote:
>> On 3/20/23 9:06?AM, Kanchan Joshi wrote:
>>> On Sun, Mar 19, 2023 at 8:51?PM Jens Axboe <[email protected]> wrote:
>>>>
>>>> This is similar to what we do on the non-passthrough read/write side,
>>>> and helps take advantage of the completion batching we can do when we
>>>> post CQEs via task_work. On top of that, this avoids a uring_lock
>>>> grab/drop for every completion.
What we should do is to pass in "bool *locked" that we use for
normal tw. I'll prep a patch converting that locked into a structure.
I'd also argue it's better to use tw from commands directly
without a second callback. That would need a couple of helpers.
--
Pavel Begunkov
next prev parent reply other threads:[~2023-03-27 11:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 15:18 [PATCH] io_uring/uring_cmd: push IRQ based completions through task_work Jens Axboe
2023-03-20 15:06 ` Kanchan Joshi
2023-03-20 20:03 ` Jens Axboe
2023-03-20 20:42 ` Jens Axboe
2023-03-21 4:32 ` Kanchan Joshi
2023-03-21 4:38 ` Kanchan Joshi
2023-03-27 11:16 ` Pavel Begunkov [this message]
2023-03-20 23:35 ` Ming Lei
2023-03-21 1:39 ` Jens Axboe
2023-03-21 1:54 ` Ming Lei
2023-03-21 1:56 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox