From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Subject: Re: [liburing PATCH] io_uring: invalid fd for file-less operations
Date: Wed, 13 Nov 2019 14:39:11 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <b74f30f890ef054cff370f3f8fae68fd264e1c5e.1573680315.git.asml.silence@gmail.com>
On 11/13/19 2:27 PM, Pavel Begunkov wrote:
> If an operation doesn't need a file, set fd to an invalid value.
> This would help to spot an unwanted fdget() in the kernel, and is
> conceptually more correct (though negotiable)
I don't think that negotiable, if we don't need a valid fd, we should
just set it to -1. I've applied this patch, thanks.
--
Jens Axboe
prev parent reply other threads:[~2019-11-13 21:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 21:27 [liburing PATCH] io_uring: invalid fd for file-less operations Pavel Begunkov
2019-11-13 21:31 ` Pavel Begunkov
2019-11-13 21:39 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox