public inbox for [email protected]
 help / color / mirror / Atom feed
From: Pavel Begunkov <[email protected]>
To: Jens Axboe <[email protected]>, io-uring <[email protected]>
Subject: Re: [PATCH] io_uring: kill io_cqring_ev_posted() and __io_cq_unlock_post()
Date: Thu, 24 Nov 2022 16:16:11 +0000	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 11/21/22 14:52, Jens Axboe wrote:
> __io_cq_unlock_post() is identical to io_cq_unlock_post(), and
> io_cqring_ev_posted() has a single caller so migth as well just inline
> it there.

It was there for one purpose, to inline it in the hottest path,
i.e. __io_submit_flush_completions(). I'll be reverting it back



> Signed-off-by: Jens Axboe <[email protected]>
> 
> ---
> 
> diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
> index 762ecab801f2..2260fb7aa7f2 100644
> --- a/io_uring/io_uring.c
> +++ b/io_uring/io_uring.c
> @@ -581,23 +581,14 @@ void __io_commit_cqring_flush(struct io_ring_ctx *ctx)
>   		io_eventfd_flush_signal(ctx);
>   }
>   
> -static inline void io_cqring_ev_posted(struct io_ring_ctx *ctx)
> -{
> -	io_commit_cqring_flush(ctx);
> -	io_cqring_wake(ctx);
> -}
> -
> -static inline void __io_cq_unlock_post(struct io_ring_ctx *ctx)
> +void io_cq_unlock_post(struct io_ring_ctx *ctx)
>   	__releases(ctx->completion_lock)
>   {
>   	io_commit_cqring(ctx);
>   	spin_unlock(&ctx->completion_lock);
> -	io_cqring_ev_posted(ctx);
> -}
>   
> -void io_cq_unlock_post(struct io_ring_ctx *ctx)
> -{
> -	__io_cq_unlock_post(ctx);
> +	io_commit_cqring_flush(ctx);
> +	io_cqring_wake(ctx);
>   }
>   
>   /* Returns true if there are no backlogged entries after the flush */
> @@ -1346,7 +1337,7 @@ static void __io_submit_flush_completions(struct io_ring_ctx *ctx)
>   		if (!(req->flags & REQ_F_CQE_SKIP))
>   			__io_fill_cqe_req(ctx, req);
>   	}
> -	__io_cq_unlock_post(ctx);
> +	io_cq_unlock_post(ctx);
>   
>   	io_free_batch_list(ctx, state->compl_reqs.first);
>   	INIT_WQ_LIST(&state->compl_reqs);
> 

-- 
Pavel Begunkov

  reply	other threads:[~2022-11-24 16:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21 14:52 [PATCH] io_uring: kill io_cqring_ev_posted() and __io_cq_unlock_post() Jens Axboe
2022-11-24 16:16 ` Pavel Begunkov [this message]
2022-11-24 18:46   ` Jens Axboe
2022-11-24 19:17     ` Pavel Begunkov
2022-11-24 19:19       ` Pavel Begunkov
2022-11-24 19:29       ` Jens Axboe
2022-11-24 19:51         ` Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox