From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A506C2B9F4 for ; Tue, 22 Jun 2021 11:42:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56557613BE for ; Tue, 22 Jun 2021 11:42:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229849AbhFVLoT (ORCPT ); Tue, 22 Jun 2021 07:44:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229912AbhFVLoT (ORCPT ); Tue, 22 Jun 2021 07:44:19 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC458C061574; Tue, 22 Jun 2021 04:42:02 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id s15so23178329edt.13; Tue, 22 Jun 2021 04:42:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MDkJckJY5oP0PWlOeAbtgHTONOMeT6CtCeOeosjNf4Q=; b=ECIDGOQN9dm7Si3hl8VbRpOS4BXSJqZ1RoWbXuK9xRFSVAEwcHJH/NIpaW395zo8YI 236aRtA20+NnQpRdCbzpNZ5t17zBHqxXudVxtvhbBc0uQQIT3QwE1l2EGuDUhs3ZMzkR NiPEdpOBsOOG/O+txGj6pvaQAZcJCUtnr17uDDMjScpwsW6owRVcXDmxGlgkkuVuEGKo CoJ2F5cwofm6yOQnw6Zm+p/3y9SFHh4AkrqYmeoZFk+p4lDdeL7vJL7bEXdg3TaEJB7k OmSXIZyYAhXcTDSkQXc2qV7Gui5vADJlFcWF/mUYBUhFXWB+DOsKJ6/1z9Xs27sVMOnt +FjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MDkJckJY5oP0PWlOeAbtgHTONOMeT6CtCeOeosjNf4Q=; b=Jj9si1G5hdTnTeQ2BrhP573CshLUrMRGGaiZLUTfX7z70UpQDyWSx/ZX6AYMJIr7zF wwQsknMBa/UH0+wBfztrEHzfBaAkM5CLLyfzCnejpyreGjYsDURCpB3sXr7Z+d5Br80F dIuKjIN4mg2wveqwdbKsreWKBct2zDPFIj17+TBGdoKwhPkryyGAVl7hP4WukGogXztT hrvzkxk4RPEaz3vQQCfgC8N+h9x4dP9uM/F6gDwmSu/mtQhvqZzsFeM6wEF6uQhRyeds o7VnG9IyKUBk+YYbaMxH9dGMY23XRUa0xZY1RitiynAzhW/LdOywXyioG0Re2dDyX49J I+sw== X-Gm-Message-State: AOAM530K7fUFiNsPLXKk7XaK1BBgGrDC4HtLJ17fF2Z7lqiHEY3wKN0U I9EaHyVnFFrhsM/rw8t/0KioeKwG7e1U0BDR X-Google-Smtp-Source: ABdhPJyElLWmFDrNBlsjQSz3a4MRqe3hqjh4lMNZZFC6efeYtYI8YGt3xy4sLXWSmAnKqKAcuxJYSg== X-Received: by 2002:a05:6402:1e8b:: with SMTP id f11mr4379593edf.86.1624362121273; Tue, 22 Jun 2021 04:42:01 -0700 (PDT) Received: from ?IPv6:2620:10d:c096:310::2410? ([2620:10d:c093:600::2:c503]) by smtp.gmail.com with ESMTPSA id e28sm9901814edc.24.2021.06.22.04.42.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Jun 2021 04:42:00 -0700 (PDT) Subject: Re: [PATCH v5 02/10] io_uring: add support for IORING_OP_MKDIRAT To: Dmitry Kadashev , Jens Axboe , Alexander Viro , Christian Brauner Cc: linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org References: <20210603051836.2614535-1-dkadashev@gmail.com> <20210603051836.2614535-3-dkadashev@gmail.com> From: Pavel Begunkov Message-ID: Date: Tue, 22 Jun 2021 12:41:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210603051836.2614535-3-dkadashev@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 6/3/21 6:18 AM, Dmitry Kadashev wrote: > IORING_OP_MKDIRAT behaves like mkdirat(2) and takes the same flags > and arguments. > > Signed-off-by: Dmitry Kadashev > --- > fs/io_uring.c | 55 +++++++++++++++++++++++++++++++++++ > include/uapi/linux/io_uring.h | 1 + > 2 files changed, 56 insertions(+) > > diff --git a/fs/io_uring.c b/fs/io_uring.c > index a1ca6badff36..8ab4eb559520 100644 > --- a/fs/io_uring.c > +++ b/fs/io_uring.c > @@ -665,6 +665,13 @@ struct io_unlink { > struct filename *filename; > }; > > +struct io_mkdir { > + struct file *file; > + int dfd; > + umode_t mode; > + struct filename *filename; > +}; > + > struct io_completion { > struct file *file; > struct list_head list; > @@ -809,6 +816,7 @@ struct io_kiocb { > struct io_shutdown shutdown; > struct io_rename rename; > struct io_unlink unlink; > + struct io_mkdir mkdir; > /* use only after cleaning per-op data, see io_clean_op() */ > struct io_completion compl; > }; > @@ -1021,6 +1029,7 @@ static const struct io_op_def io_op_defs[] = { > }, > [IORING_OP_RENAMEAT] = {}, > [IORING_OP_UNLINKAT] = {}, > + [IORING_OP_MKDIRAT] = {}, > }; > > static bool io_disarm_next(struct io_kiocb *req); > @@ -3530,6 +3539,44 @@ static int io_unlinkat(struct io_kiocb *req, unsigned int issue_flags) > return 0; > } > > +static int io_mkdirat_prep(struct io_kiocb *req, > + const struct io_uring_sqe *sqe) > +{ > + struct io_mkdir *mkd = &req->mkdir; > + const char __user *fname; > + > + if (unlikely(req->flags & REQ_F_FIXED_FILE)) > + return -EBADF; > + > + mkd->dfd = READ_ONCE(sqe->fd); > + mkd->mode = READ_ONCE(sqe->len); > + > + fname = u64_to_user_ptr(READ_ONCE(sqe->addr)); > + mkd->filename = getname(fname); > + if (IS_ERR(mkd->filename)) > + return PTR_ERR(mkd->filename); We have to check unused fields, e.g. buf_index and off, to be able to use them in the future if needed. if (sqe->buf_index || sqe->off) return -EINVAL; Please double check what fields are not used, and same goes for all other opcodes. > + > + req->flags |= REQ_F_NEED_CLEANUP; > + return 0; > +} > + > +static int io_mkdirat(struct io_kiocb *req, int issue_flags) > +{ > + struct io_mkdir *mkd = &req->mkdir; > + int ret; > + > + if (issue_flags & IO_URING_F_NONBLOCK) > + return -EAGAIN; > + > + ret = do_mkdirat(mkd->dfd, mkd->filename, mkd->mode); > + > + req->flags &= ~REQ_F_NEED_CLEANUP; > + if (ret < 0) > + req_set_fail_links(req); > + io_req_complete(req, ret); > + return 0; > +} > + > static int io_shutdown_prep(struct io_kiocb *req, > const struct io_uring_sqe *sqe) > { > @@ -5936,6 +5983,8 @@ static int io_req_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) > return io_renameat_prep(req, sqe); > case IORING_OP_UNLINKAT: > return io_unlinkat_prep(req, sqe); > + case IORING_OP_MKDIRAT: > + return io_mkdirat_prep(req, sqe); > } > > printk_once(KERN_WARNING "io_uring: unhandled opcode %d\n", > @@ -6077,6 +6126,9 @@ static void io_clean_op(struct io_kiocb *req) > case IORING_OP_UNLINKAT: > putname(req->unlink.filename); > break; > + case IORING_OP_MKDIRAT: > + putname(req->mkdir.filename); > + break; > } > req->flags &= ~REQ_F_NEED_CLEANUP; > } > @@ -6203,6 +6255,9 @@ static int io_issue_sqe(struct io_kiocb *req, unsigned int issue_flags) > case IORING_OP_UNLINKAT: > ret = io_unlinkat(req, issue_flags); > break; > + case IORING_OP_MKDIRAT: > + ret = io_mkdirat(req, issue_flags); > + break; > default: > ret = -EINVAL; > break; > diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h > index e1ae46683301..bf9d720d371f 100644 > --- a/include/uapi/linux/io_uring.h > +++ b/include/uapi/linux/io_uring.h > @@ -137,6 +137,7 @@ enum { > IORING_OP_SHUTDOWN, > IORING_OP_RENAMEAT, > IORING_OP_UNLINKAT, > + IORING_OP_MKDIRAT, > > /* this goes last, obviously */ > IORING_OP_LAST, > -- Pavel Begunkov