From: Pavel Begunkov <asml.silence@gmail.com>
To: io-uring@vger.kernel.org
Cc: asml.silence@gmail.com
Subject: [PATCH 4/4] io_uring: add lockdep warning for overflow posting
Date: Wed, 14 May 2025 09:07:23 +0100 [thread overview]
Message-ID: <c187a13dfee3a73fcf4f28a05d72e07cf146e924.1747209332.git.asml.silence@gmail.com> (raw)
In-Reply-To: <cover.1747209332.git.asml.silence@gmail.com>
io_cqring_event_overflow() must be called in the same CQ protection
section as the preceding io_get_cqe(), otherwise overflowed and normal
CQEs can get out of order. It's hard to debug check that exactly, but we
can verify that io_cqring_event_overflow() is called with the CQ locked,
which should be good enough to catch most cases of misuse.
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
io_uring/io_uring.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index 927d8e45dbdb..da1075b66a87 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -754,6 +754,8 @@ static bool io_cqring_event_overflow(struct io_ring_ctx *ctx, bool locked,
gfp_t gfp = GFP_KERNEL_ACCOUNT;
bool queued;
+ io_lockdep_assert_cq_locked(ctx);
+
if (is_cqe32)
ocq_size += sizeof(struct io_uring_cqe);
if (locked)
--
2.49.0
prev parent reply other threads:[~2025-05-14 8:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 8:07 [PATCH 0/4] overflow completion enhancements Pavel Begunkov
2025-05-14 8:07 ` [PATCH 1/4] io_uring: open code io_req_cqe_overflow() Pavel Begunkov
2025-05-14 8:07 ` [PATCH 2/4] io_uring: move locking inside overflow posting Pavel Begunkov
2025-05-14 16:42 ` Jens Axboe
2025-05-14 17:18 ` Pavel Begunkov
2025-05-14 19:25 ` Jens Axboe
2025-05-14 20:00 ` Pavel Begunkov
2025-05-14 20:05 ` Jens Axboe
2025-05-14 21:52 ` Jens Axboe
2025-05-15 11:04 ` Pavel Begunkov
2025-05-14 8:07 ` [PATCH 3/4] io_uring: alloc overflow entry before locking Pavel Begunkov
2025-05-14 8:07 ` Pavel Begunkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c187a13dfee3a73fcf4f28a05d72e07cf146e924.1747209332.git.asml.silence@gmail.com \
--to=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox