public inbox for [email protected]
 help / color / mirror / Atom feed
From: Olivier Langlois <[email protected]>
To: Jens Axboe <[email protected]>,
	Pavel Begunkov <[email protected]>,
	 [email protected]
Subject: Re: [PATCH v2] io_uring: do the sqpoll napi busy poll outside the submission block
Date: Mon, 12 Aug 2024 17:50:21 -0400	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On Mon, 2024-08-12 at 14:31 -0600, Jens Axboe wrote:
> On 7/30/24 3:10 PM, Olivier Langlois wrote:
> > diff --git a/io_uring/napi.h b/io_uring/napi.h
> > index 88f1c21d5548..5506c6af1ff5 100644
> > --- a/io_uring/napi.h
> > +++ b/io_uring/napi.h
> > @@ -101,4 +101,13 @@ static inline int
> > io_napi_sqpoll_busy_poll(struct io_ring_ctx *ctx)
> >  }
> >  #endif /* CONFIG_NET_RX_BUSY_POLL */
> >  
> > +static inline int io_do_sqpoll_napi(struct io_ring_ctx *ctx)
> > +{
> > +	int ret = 0;
> > +
> > +	if (io_napi(ctx))
> > +		ret = io_napi_sqpoll_busy_poll(ctx);
> > +	return ret;
> > +}
> > +
> 
> static inline int io_do_sqpoll_napi(struct io_ring_ctx *ctx)
> {
> 	if (io_napi(ctx))
> 		return io_napi_sqpoll_busy_poll(ctx);
> 	return 0;
> }
> 
> is a less convoluted way of doing the same.

I agree. but if I am to produce a 3rd version. How about even not
returning anything at all since the caller ignores the return value?

I was hesitating about doing this but I did figure that a reviewer
would point it out if it was the right thing to do...


  reply	other threads:[~2024-08-12 21:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-30 21:10 [PATCH v2] io_uring: do the sqpoll napi busy poll outside the submission block Olivier Langlois
2024-08-12 20:29 ` Olivier Langlois
2024-08-12 20:31 ` Jens Axboe
2024-08-12 21:50   ` Olivier Langlois [this message]
2024-08-12 21:51     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1a333db6bce30ac770a590f80f3d26e945c5065.camel@trillion01.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox