From: Jens Axboe <[email protected]>
To: Hao Xu <[email protected]>
Cc: [email protected], Pavel Begunkov <[email protected]>,
Joseph Qi <[email protected]>
Subject: Re: [PATCH v3] io-wq: simplify code in __io_worker_busy
Date: Mon, 5 Apr 2021 15:46:47 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 4/5/21 1:53 AM, Hao Xu wrote:
> leverage xor to simplify code in __io_worker_busy
>
> Signed-off-by: Hao Xu <[email protected]>
> ---
> fs/io-wq.c | 17 +++++++----------
> 1 file changed, 7 insertions(+), 10 deletions(-)
>
> diff --git a/fs/io-wq.c b/fs/io-wq.c
> index 433c4d3c3c1c..8d8324eba2ec 100644
> --- a/fs/io-wq.c
> +++ b/fs/io-wq.c
> @@ -276,10 +276,12 @@ static void io_wqe_dec_running(struct io_worker *worker)
> */
> static void __io_worker_busy(struct io_wqe *wqe, struct io_worker *worker,
> struct io_wq_work *work)
> - __must_hold(wqe->lock)
> + __must_hold(w qe->lock)
Looks like something is off there? I see a v2 as well, but this one is
later, so...
--
Jens Axboe
next prev parent reply other threads:[~2021-04-05 21:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 10:18 [PATCH] io-wq: simplify code in __io_worker_busy Hao Xu
2021-04-02 10:38 ` Pavel Begunkov
2021-04-04 19:17 ` Jens Axboe
2021-04-05 7:53 ` [PATCH v3] " Hao Xu
2021-04-05 21:46 ` Jens Axboe [this message]
2021-04-06 2:18 ` Hao Xu
2021-04-06 3:08 ` [PATCH v4] " Hao Xu
2021-04-06 15:36 ` Jens Axboe
2021-04-07 18:28 ` Pavel Begunkov
2021-04-05 7:36 ` [PATCH v2] " Hao Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox