[PATCH] io_uring: remove dead code after drain rework

[PATCH] io_uring: remove dead code after drain rework

[Pavel Begunkov]

io_drain_req() uses a helper function for counting the number of
requests in a link, remove unused open coded accounting that
was accidentially left.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202505100200.cyy3V6oJ-lkp@intel.com/
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---

Should also be fine to squash into the original patch

 io_uring/io_uring.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index 0fda1b1a33ae..41f8709abfc5 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -1649,8 +1649,6 @@ static __cold void io_drain_req(struct io_kiocb *req)
 	struct io_ring_ctx *ctx = req->ctx;
 	bool drain = req->flags & IOSQE_IO_DRAIN;
 	struct io_defer_entry *de;
-	struct io_kiocb *tmp;
-	int nr = 0;
 
 	de = kmalloc(sizeof(*de), GFP_KERNEL_ACCOUNT);
 	if (!de) {
@@ -1658,8 +1656,6 @@ static __cold void io_drain_req(struct io_kiocb *req)
 		return;
 	}
 
-	io_for_each_link(tmp, req)
-		nr++;
 	io_prep_async_link(req);
 	trace_io_uring_defer(req);
 	de->req = req;
-- 
2.49.0

Re: [PATCH] io_uring: remove dead code after drain rework

[Jens Axboe]

On 5/11/25 2:01 AM, Pavel Begunkov wrote:
> io_drain_req() uses a helper function for counting the number of
> requests in a link, remove unused open coded accounting that
> was accidentially left.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202505100200.cyy3V6oJ-lkp@intel.com/
> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
> ---
> 
> Should also be fine to squash into the original patch

Squashed, thanks.

-- 
Jens Axboe