From: Jens Axboe <axboe@kernel.dk>
To: Gabriel Krisman Bertazi <krisman@suse.de>
Cc: netdev@vger.kernel.org, io-uring@vger.kernel.org,
Jakub Kicinski <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH 0/3] Introduce getsockname io_uring_cmd
Date: Sat, 25 Oct 2025 07:27:37 -0600 [thread overview]
Message-ID: <c344d845-99ba-4c3c-9382-cf401712a689@kernel.dk> (raw)
In-Reply-To: <20251024154901.797262-1-krisman@suse.de>
On 10/24/25 9:48 AM, Gabriel Krisman Bertazi wrote:
>
> This feature has been requested a few times in the liburing repository
> and Discord channels, such as in [1,2]. If anything, it also helps
> solve a long standing issue in the bind-listen test that results in
> occasional test failures.
>
> The patchset is divided in three parts: Patch 1 merges the getpeername
> and getsockname implementation in the network layer, making further
> patches easier; Patch 2 splits out a helper used by io_uring, like done
> for other network commands; Finally, patch 3 plumbs the new command in
> io_uring.
>
> The syscall path was tested by booting a Linux distro, which does all
> sorts of getsockname/getpeername syscalls. The io_uring side was tested
> with a couple of new liburing subtests available at:
>
> https://github.com/krisman/liburing.git -b socket
>
> Based on top of Jens' for-next.
>
> [1] https://github.com/axboe/liburing/issues/1356
> [2] https://discord.com/channels/1241076672589991966/1241076672589991970/1429975797912830074
Looks good to me, and it's not often you can add a new feature and
have:
> 5 files changed, 52 insertions(+), 52 deletions(-)
a net zero diffstat! Nice.
--
Jens Axboe
next prev parent reply other threads:[~2025-10-25 13:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 15:48 [PATCH 0/3] Introduce getsockname io_uring_cmd Gabriel Krisman Bertazi
2025-10-24 15:48 ` [PATCH 1/3] socket: Unify getsockname and getpeername implementation Gabriel Krisman Bertazi
2025-10-24 15:48 ` [PATCH 2/3] socket: Split out a getsockname helper for io_uring Gabriel Krisman Bertazi
2025-10-24 15:49 ` [PATCH 3/3] io_uring: Introduce getsockname io_uring cmd Gabriel Krisman Bertazi
2025-10-25 13:27 ` Jens Axboe
2025-10-27 21:20 ` Gabriel Krisman Bertazi
2025-10-27 21:48 ` Jens Axboe
2025-10-25 13:27 ` Jens Axboe [this message]
2025-11-19 23:30 ` [PATCH 0/3] Introduce getsockname io_uring_cmd Jens Axboe
2025-11-20 1:29 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c344d845-99ba-4c3c-9382-cf401712a689@kernel.dk \
--to=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=io-uring@vger.kernel.org \
--cc=krisman@suse.de \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox