public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jens Axboe <[email protected]>
To: Hao Xu <[email protected]>, [email protected]
Cc: Pavel Begunkov <[email protected]>
Subject: Re: [PATCH v5 0/4] fast poll multishot mode
Date: Mon, 9 May 2022 21:22:23 -0600	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 5/9/22 9:15 PM, Jens Axboe wrote:
> On 5/8/22 9:43 AM, Hao Xu wrote:
>> Sorry for polluting the list, not sure why the cover-letter isn't
>> wired with the other patches..
> 
> Yeah not sure what's going on, but at least they are making it
> through... Maybe we should base this on the
> for-5.19/io_uring-alloc-fixed branch? The last patch needs to be updated
> for that anyway. I'd think the only sane check there now is if it's a
> multishot direct accept request, then the request must also specify
> IORING_FILE_INDEX_ALLOC to ensure that we allocate descriptors.

Oh, and I'm assuming you added some comprehensive tests for this for
liburing? Both functionally, but also checking the cases that should
fail (like mshot + fixed without alloc, etc). When you send out the
next/final version, would be great if you could do a the same for the
liburing side.

-- 
Jens Axboe


  reply	other threads:[~2022-05-10  3:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-08 15:37 [PATCH v5 0/4] fast poll multishot mode Hao Xu
2022-05-08 15:43 ` Hao Xu
2022-05-10  3:15   ` Jens Axboe
2022-05-10  3:22     ` Jens Axboe [this message]
2022-05-10  4:18       ` Hao Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox