From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1D2EC77B75 for ; Mon, 15 May 2023 19:55:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243866AbjEOTzn (ORCPT ); Mon, 15 May 2023 15:55:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242268AbjEOTzm (ORCPT ); Mon, 15 May 2023 15:55:42 -0400 Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76C6BE727 for ; Mon, 15 May 2023 12:55:41 -0700 (PDT) Received: by mail-il1-x12a.google.com with SMTP id e9e14a558f8ab-3357ea1681fso3100065ab.1 for ; Mon, 15 May 2023 12:55:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1684180541; x=1686772541; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eP6gErIx4YH4NGO5e9TOO4EyxDdPvqOfbtAqJSgrrUw=; b=BCWyQw0mDG8PUE2P9cmJlB519vHPXHbntbFnNnbkKzNif9qWqrBfTQbKPKN7qmBca6 dP4FZxbQD4m2WdjZWqcwzj3viM7yPrEGIB92FmyQxFtHR7oAb7uhqpEy9CM/JPp1bMNY xyWNRZmN2rK6BjAB1a3uXYmyBjanEC22eb+/b2K1Yosr+j70fmB4bAiaCylRWFnZLISt dk5NsKcFoL5JwEf7MIFopajKeA9S/gmSkyGl7+r0XSNwbWuzxSDL/q4vkdgUN6FMqupO Pp9QcJdfKZZc9z89NXYBLn27oRLDK8Vo4zZUhRbhVpClZVj+dY7g4IXQIOT5XvKNneDE BiSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684180541; x=1686772541; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eP6gErIx4YH4NGO5e9TOO4EyxDdPvqOfbtAqJSgrrUw=; b=XKNZtHVbE9yRsJfWXwludtmRFzyssAVqUQKQoeC1XYMrvB3UozbAj5+1CDz3ydwXf5 E+p7bk43US2jFOk9X+Hb4W/0YHBErUzXCTk/YOGCL02qAKtIQ//zoSFDkJymmNfXaYTM Nn7BIUmM7PpT3tnT0j8Wc21O+/MebAoGgBsO5b4mrSgxsv4vLApyaDlLB8wl27MtSvs3 6od9U04GcZrL7AQ6P5BCmEJemV/4znHUDvuymCK46al6qXi2kv2gSFLjebrszaSWN/Q7 HDzBcsayFqGjiYfHC6bRjUSQWcmdwLppAJffDIGCheY+CFiNbv9fhbFt1gT47njHHoce 72ew== X-Gm-Message-State: AC+VfDzJbR8Po2chL/dbT+9D5xzrXXekheqdTWKi4t4Lv5hni1TQslA1 08NQVX7sPm8e5Aw/hMllBmn4+Q== X-Google-Smtp-Source: ACHHUZ5rJ2De8akBony3bYEhb8qsybCB8JhJ6D24MoOXnAHLUN1yyk7C43ZDv6xNI1JKHjcHFiEipQ== X-Received: by 2002:a6b:b2c7:0:b0:76c:6fa4:4df4 with SMTP id b190-20020a6bb2c7000000b0076c6fa44df4mr336763iof.2.1684180540777; Mon, 15 May 2023 12:55:40 -0700 (PDT) Received: from [192.168.1.94] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id q3-20020a027b03000000b0041672c963b3sm6021255jac.50.2023.05.15.12.55.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 May 2023 12:55:39 -0700 (PDT) Message-ID: Date: Mon, 15 May 2023 13:55:38 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v5 4/6] io_uring: rsrc: delegate VMA file-backed check to GUP Content-Language: en-US To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Cc: Matthew Wilcox , David Hildenbrand , Pavel Begunkov , io-uring@vger.kernel.org, Jason Gunthorpe , John Hubbard References: <642128d50f5423b3331e3108f8faf6b8ac0d957e.1684097002.git.lstoakes@gmail.com> From: Jens Axboe In-Reply-To: <642128d50f5423b3331e3108f8faf6b8ac0d957e.1684097002.git.lstoakes@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 5/14/23 3:26 PM, Lorenzo Stoakes wrote: > Now that the GUP explicitly checks FOLL_LONGTERM pin_user_pages() for > broken file-backed mappings in "mm/gup: disallow FOLL_LONGTERM GUP-nonfast > writing to file-backed mappings", there is no need to explicitly check VMAs > for this condition, so simply remove this logic from io_uring altogether. Don't have the prerequisite patch handy (not in mainline yet), but if it just moves the check, then: Reviewed-by: Jens Axboe -- Jens Axboe