From: Jens Axboe <[email protected]>
To: Dmitrii Dolgov <[email protected]>, [email protected]
Subject: Re: [RFC] Check if file_data is initialized
Date: Thu, 9 Jan 2020 07:45:16 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 1/9/20 6:17 AM, Dmitrii Dolgov wrote:
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index c770c2c0eb52..c5e69dfc0221 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -1232,7 +1232,8 @@ static void io_free_req_many(struct io_ring_ctx *ctx, struct req_batch *rb)
> do_free:
> kmem_cache_free_bulk(req_cachep, rb->to_free, rb->reqs);
> percpu_ref_put_many(&ctx->refs, rb->to_free);
> - percpu_ref_put_many(&ctx->file_data->refs, rb->to_free);
> + if (ctx->file_data)
> + percpu_ref_put_many(&ctx->file_data->refs, rb->to_free);
> rb->to_free = rb->need_iter = 0;
> }
Can you check with just the two ref_put lines swapped? Ala:
percpu_ref_put_many(&ctx->file_data->refs, rb->to_free);
percpu_ref_put_many(&ctx->refs, rb->to_free);
--
Jens Axboe
prev parent reply other threads:[~2020-01-09 14:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 13:17 [RFC] Check if file_data is initialized Dmitrii Dolgov
2020-01-09 14:26 ` Pavel Begunkov
2020-01-09 14:51 ` Jens Axboe
2020-01-09 15:17 ` Pavel Begunkov
2020-01-09 15:23 ` Jens Axboe
2020-01-09 15:32 ` Pavel Begunkov
2020-01-09 15:34 ` Jens Axboe
2020-01-09 16:04 ` Dmitry Dolgov
2020-01-09 16:19 ` Jens Axboe
2020-01-09 14:45 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox