public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Cc: David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v2 0/3] io_uring mm related abuses
Date: Wed, 25 Jun 2025 16:36:29 -0600	[thread overview]
Message-ID: <c79a3aff-6b39-4040-94ec-2c6bf925af67@kernel.dk> (raw)
In-Reply-To: <adfde1ba-68fa-4bcc-a657-86e0d311bdd2@gmail.com>

On 6/25/25 2:24 PM, Pavel Begunkov wrote:
> On 6/25/25 03:52, Jens Axboe wrote:
>> On 6/24/25 7:40 AM, Pavel Begunkov wrote:
>>> Patch 1 uses unpin_user_folio instead of the page variant.
>>> Patches 2-3 make sure io_uring doesn't make any assumptions
>>> about user pointer alignments.
>>>
>>> v2: change patch 1 tags
>>>      use folio_page_idx()
>>>
>>> Pavel Begunkov (3):
>>>    io_uring/rsrc: fix folio unpinning
>>>    io_uring/rsrc: don't rely on user vaddr alignment
>>>    io_uring: don't assume uaddr alignment in io_vec_fill_bvec
>>>
>>>   io_uring/rsrc.c | 27 ++++++++++++++++++++-------
>>>   io_uring/rsrc.h |  1 +
>>>   2 files changed, 21 insertions(+), 7 deletions(-)
>>
>> Hand applied, as this is against an older tree. Please check patch 1
>> in the current tree. Thanks!
> 
> Turned to be for-next from a couple of days ago. Patch 1
> looks the same, should be fine.

I don't always put current fixes in for-next, though I've tried to do it
consistently more recently. But it's conflicting with the error path
cleanup from about a week ago:

commit e1c75831f682eef0f68b35723437146ed86070b1 (tag: io_uring-6.16-20250619)
Author: Penglei Jiang <superman.xpt@gmail.com>
Date:   Tue Jun 17 09:56:44 2025 -0700

    io_uring: fix potential page leak in io_sqe_buffer_register()

and my hand-edit just put your hunk 2 of patch 1 into that cleanup path
too. Thanks for checking!

-- 
Jens Axboe

  reply	other threads:[~2025-06-25 22:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-24 13:40 [PATCH v2 0/3] io_uring mm related abuses Pavel Begunkov
2025-06-24 13:40 ` [PATCH v2 1/3] io_uring/rsrc: fix folio unpinning Pavel Begunkov
2025-06-25  7:53   ` David Hildenbrand
2025-06-25 20:33     ` Pavel Begunkov
2025-06-24 13:40 ` [PATCH v2 2/3] io_uring/rsrc: don't rely on user vaddr alignment Pavel Begunkov
2025-06-26  9:30   ` David Hildenbrand
2025-06-24 13:40 ` [PATCH v2 3/3] io_uring: don't assume uaddr alignment in io_vec_fill_bvec Pavel Begunkov
2025-06-25  2:52 ` [PATCH v2 0/3] io_uring mm related abuses Jens Axboe
2025-06-25 20:24   ` Pavel Begunkov
2025-06-25 22:36     ` Jens Axboe [this message]
2025-06-25  2:52 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c79a3aff-6b39-4040-94ec-2c6bf925af67@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=asml.silence@gmail.com \
    --cc=david@redhat.com \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox