From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>,
[email protected], [email protected]
Subject: Re: [PATCH 1/1] io-wq: close cancel gap for hashed linked work
Date: Sun, 22 Mar 2020 11:04:55 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <b9bc821a0ff3bc52a60281d8a9005dff93f6dcc3.1584893591.git.asml.silence@gmail.com>
On 3/22/20 10:14 AM, Pavel Begunkov wrote:
> After io_assign_current_work() of a linked work, it can be decided to
> offloaded to another thread so doing io_wqe_enqueue(). However, until
> next io_assign_current_work() it can be cancelled, that isn't handled.
>
> Don't assign it, if it's not going to be executed.
This needs a Fixes: line as well. I'm guessing like this:
Fixes: 60cf46ae6054 ("io-wq: hash dependent work")
but I didn't look too closely yet... Fix looks good, though.
--
Jens Axboe
next prev parent reply other threads:[~2020-03-22 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 16:14 [PATCH 1/1] io-wq: close cancel gap for hashed linked work Pavel Begunkov
2020-03-22 17:04 ` Jens Axboe [this message]
2020-03-22 17:31 ` Pavel Begunkov
2020-03-22 17:33 ` [PATCH v2] " Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox