public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Subject: Re: [PATCH for-next 0/4] cleanups around request preps
Date: Wed, 30 Sep 2020 21:01:47 -0600	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 9/30/20 1:57 PM, Pavel Begunkov wrote:
> [3/4] is splitting io_issue_sqe() as someone once proposed. (I can't
> find who it was and the thread). Hopefully, it doesn't add much
> overhead.
> 
> Apart from massive deduplication, this also reduces sqe propagation
> depth, that's a good thing.
> 
> Pavel Begunkov (4):
>   io_uring: set/clear IOCB_NOWAIT into io_read/write
>   io_uring: remove nonblock arg from io_{rw}_prep()
>   io_uring: decouple issuing and req preparation
>   io_uring: move req preps out of io_issue_sqe()
> 
>  fs/io_uring.c | 316 ++++++++++++--------------------------------------
>  1 file changed, 77 insertions(+), 239 deletions(-)

Thanks, this is awesome! Easier to read, and kills a ton of lines.
I have applied this and your standalone patches.

-- 
Jens Axboe


      parent reply	other threads:[~2020-10-01  3:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 19:57 [PATCH for-next 0/4] cleanups around request preps Pavel Begunkov
2020-09-30 19:57 ` [PATCH 1/4] io_uring: set/clear IOCB_NOWAIT into io_read/write Pavel Begunkov
2020-09-30 19:57 ` [PATCH 2/4] io_uring: remove nonblock arg from io_{rw}_prep() Pavel Begunkov
2020-09-30 19:57 ` [PATCH 3/4] io_uring: decouple issuing and req preparation Pavel Begunkov
2020-09-30 19:57 ` [PATCH 4/4] io_uring: move req preps out of io_issue_sqe() Pavel Begunkov
2020-10-01  3:01 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox