From: Jens Axboe <axboe@kernel.dk>
To: io-uring <io-uring@vger.kernel.org>
Subject: [PATCH] io_uring/io-wq: handle !sysctl_hung_task_timeout_secs
Date: Fri, 23 Jan 2026 14:00:28 -0700 [thread overview]
Message-ID: <ca34d302-6a65-4188-85e1-f731cc713aca@kernel.dk> (raw)
If the hung_task_timeout sysctl is set to 0, then we'll end up busy
looping inside io_wq_exit_workers() after an earlier commit switched to
using wait_for_completion_timeout(). Use the maximum schedule timeout
value for that case.
Fixes: 1f293098a313 ("io_uring/io-wq: don't trigger hung task for syzbot craziness")
Reported-by: Chris Mason <clm@fb.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
diff --git a/io_uring/io-wq.c b/io_uring/io-wq.c
index aaf1dfc21763..3b55feb620d9 100644
--- a/io_uring/io-wq.c
+++ b/io_uring/io-wq.c
@@ -1340,6 +1340,8 @@ static void io_wq_exit_workers(struct io_wq *wq)
* up waiting more than IO_URING_EXIT_WAIT_MAX.
*/
timeout = sysctl_hung_task_timeout_secs * HZ / 2;
+ if (!timeout)
+ timeout = MAX_SCHEDULE_TIMEOUT;
warn_timeout = jiffies + IO_URING_EXIT_WAIT_MAX;
do {
if (wait_for_completion_timeout(&wq->worker_done, timeout))
--
Jens Axboe
reply other threads:[~2026-01-23 21:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca34d302-6a65-4188-85e1-f731cc713aca@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox