From: Pavel Begunkov <[email protected]>
To: [email protected], Christian Brauner <[email protected]>,
[email protected]
Cc: [email protected], "Darrick J . Wong" <[email protected]>,
[email protected], wu lei <[email protected]>
Subject: [PATCH 1/1] iomap: propagate nowait to block layer
Date: Wed, 26 Feb 2025 01:33:58 +0000 [thread overview]
Message-ID: <ca8f7e4efb902ee6500ab5b1fafd67acb3224c45.1740533564.git.asml.silence@gmail.com> (raw)
There are reports of high io_uring submission latency for ext4 and xfs,
which is due to iomap not propagating nowait flag to the block layer
resulting in waiting for IO during tag allocation.
Cc: [email protected]
Link: https://github.com/axboe/liburing/issues/826#issuecomment-2674131870
Reported-by: wu lei <[email protected]>
Signed-off-by: Pavel Begunkov <[email protected]>
---
fs/iomap/direct-io.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
index b521eb15759e..25c5e87dbd94 100644
--- a/fs/iomap/direct-io.c
+++ b/fs/iomap/direct-io.c
@@ -81,6 +81,9 @@ static void iomap_dio_submit_bio(const struct iomap_iter *iter,
WRITE_ONCE(iocb->private, bio);
}
+ if (iocb->ki_flags & IOCB_NOWAIT)
+ bio->bi_opf |= REQ_NOWAIT;
+
if (dio->dops && dio->dops->submit_io)
dio->dops->submit_io(iter, bio, pos);
else
--
2.48.1
next reply other threads:[~2025-02-26 1:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 1:33 Pavel Begunkov [this message]
2025-02-26 1:53 ` [PATCH 1/1] iomap: propagate nowait to block layer Darrick J. Wong
2025-02-26 2:06 ` Pavel Begunkov
2025-02-26 2:20 ` Darrick J. Wong
2025-02-26 2:46 ` Pavel Begunkov
2025-02-26 4:52 ` Dave Chinner
2025-02-26 12:33 ` Pavel Begunkov
2025-02-26 20:49 ` Dave Chinner
2025-02-27 11:58 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca8f7e4efb902ee6500ab5b1fafd67acb3224c45.1740533564.git.asml.silence@gmail.com \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox