From: Jens Axboe <[email protected]>
To: Olivier Langlois <[email protected]>,
Pavel Begunkov <[email protected]>,
[email protected]
Subject: Re: [PATCH v2] liburing: Add io_uring_submit_and_wait_timeout function in API
Date: Mon, 4 Oct 2021 17:32:29 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <1bbde6755535cb7b0bdfc0846254e7c06faf04e0.1633366467.git.olivier@trillion01.com>
On 10/4/21 10:56 AM, Olivier Langlois wrote:
> before commit 0ea4ccd1c0e4 ("src/queue: don't flush SQ ring for new wait interface"),
> io_uring_wait_cqes() was serving the purpose of submit sqe and wait for cqe up to a certain timeout value.
I fixed up this to wrap at 74 chars (standard style) to avoid wrapping
in git log reading, and fixed up:
> + if (to_submit < 0)
> + return to_submit;
> }
> + else
> + to_submit = __io_uring_flush_sq(ring);
>
> return __io_uring_get_cqe(ring, cqe_ptr, to_submit, wait_nr, sigmask);
> }
>
this else condition which was still on a separate line. Applied, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2021-10-04 23:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 16:56 [PATCH v2] liburing: Add io_uring_submit_and_wait_timeout function in API Olivier Langlois
2021-10-04 23:32 ` Jens Axboe [this message]
2021-10-05 22:30 ` [PATCH] Fix typo "timout" -> "timeout" Ammar Faizi
2021-10-05 22:41 ` Jens Axboe
2021-12-06 19:45 ` Olivier Langlois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox