From: David Laight <[email protected]>
To: 'Christoph Hellwig' <[email protected]>
Cc: "[email protected]" <[email protected]>,
"[email protected]" <[email protected]>,
"[email protected]" <[email protected]>,
Jens Axboe <[email protected]>,
"David S. Miller" <[email protected]>,
Al Viro <[email protected]>,
linux-fsdevel <[email protected]>
Subject: RE: [PATCH 5/9 next] scsi: Use iovec_import() instead of import_iovec().
Date: Mon, 21 Sep 2020 14:50:01 +0000 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
From: Christoph Hellwig
> Sent: 21 September 2020 15:22
>
> So looking at the various callers I'm not sure this API is the
> best. If we want to do something fancy I'd hide the struct iovec
> instances entirely with something like:
>
> struct iov_storage {
> struct iovec stack[UIO_FASTIOV], *vec;
> }
>
> int iov_iter_import_iovec(struct iov_iter *iter, struct iov_storage *s,
> const struct iovec __user *vec, unsigned long nr_segs,
> int type);
>
> and then add a new helper to free the thing if needed:
>
> void iov_iter_release_iovec(struct iov_storage *s)
> {
> if (s->vec != s->stack)
> kfree(s->vec);
> }
I didn't think of going that far.
There are 2 call sites (in scsi) that don't pass the cache.
Given that the 'buffer to free' address probably needs to
be spilled to stack forcing in into an on-stack structure
that is already passed by address is probably a good idea.
The iov_iter_release_iovec() should be static inline and just:
if (s->vec)
kfree(s->vec);
You want the test because 99.99% of the time it will be NULL.
The kernel iov[] to use is iter.iov not part of the cache.
That will be a bigger change on the io_uring code.
(The patch I didn't write.)
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2020-09-21 14:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 14:55 [PATCH 5/9 next] scsi: Use iovec_import() instead of import_iovec() David Laight
2020-09-21 14:22 ` Christoph Hellwig
2020-09-21 14:50 ` David Laight [this message]
2021-01-08 11:13 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox