From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCE22C35DEE for ; Tue, 25 Feb 2020 02:24:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9E5DB2176D for ; Tue, 25 Feb 2020 02:24:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="pQ9W2Hnv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728869AbgBYCYn (ORCPT ); Mon, 24 Feb 2020 21:24:43 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:41921 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728843AbgBYCYm (ORCPT ); Mon, 24 Feb 2020 21:24:42 -0500 Received: by mail-pf1-f196.google.com with SMTP id j9so6360605pfa.8 for ; Mon, 24 Feb 2020 18:24:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YbgGKrqNaKXp2P1o2CFhhdjDJfnvbygLowAWzXITc0o=; b=pQ9W2Hnv2ST8c3qN2fi+GCnKQg8phWjO/yITBWU7lVXRtGSK0BxYYEyYmDrDzJKMzB 4SQoSw2iaQdUd0HADngXJvdAKYvMRCudTDn8Km1ZcAiAoDsbkbz8g7lnAn9U5rb72Jbc ummSJI5Tl7A/Jb9u5+8MGt9ZDnYzzEax0jykd3Ra3mg0GqzwuBIUSX5uYAkDuRE2JSuk CglJXHJVIEKTpIzWM6Ibv5D3UTFntIWb0EoP5RfAS62IdrkluUZ68pExflwkQ+M8UOCt b/CZwWj/vWfMRW+bejcwh9tYM9IjyAlCHRX3zvVlJYt6e9T8UebumbSFCXnC7+fcVeU5 d6gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YbgGKrqNaKXp2P1o2CFhhdjDJfnvbygLowAWzXITc0o=; b=tj2Hrq2nu6Fk0pFlPkb/fBlSi6mkTLrYuZumEK1r1mow6zARGHHq7RZk+/Q7ixlaot TacBbxyB0Kj4vo4A2k9RkF92cqHbIlt7mLQy1n5ZeZmMzvZgfCWVPkWTZl5hmFkejz87 aJQWedhFS2BkRjSSlL/1KrUn6K+zWNpW3DKiiAoFaHyIe84qIEVcIczoXOn2H2nEt3tP S+3qiR8lFiPYO5doiaMeRlDUZ+WbXP09oy+Z9Kjc4Ri5CflWJQHk2T2588n5B9gdJYok 2hEtAu1NKIqIQSXJwFFsLGJoyw3xW+Tp9wmaWQW9NRI+BxG392Ut2asxHkc74E2EDX9I M25A== X-Gm-Message-State: APjAAAVcqkHYozHCykLy2Tb00T9KuTiKfEreMbglLCUpe83GWIjMMmBm WZmbCioeXjJQ7r8REvoTsViCqw== X-Google-Smtp-Source: APXvYqxjwFg+b82hQJR4vQpUyb6M+nTgv+CVa2mYd/vuiLte+VdequLaoFu6XweGKMnyUWMYsXHVkw== X-Received: by 2002:a05:6a00:45:: with SMTP id i5mr53824302pfk.252.1582597480784; Mon, 24 Feb 2020 18:24:40 -0800 (PST) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id c188sm14713490pfb.151.2020.02.24.18.24.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Feb 2020 18:24:40 -0800 (PST) Subject: Re: [PATCH v3] io_uring: fix poll_list race for SETUP_IOPOLL|SETUP_SQPOLL To: Xiaoguang Wang , io-uring@vger.kernel.org Cc: linux-ext4@vger.kernel.org, joseph.qi@linux.alibaba.com References: <20200224070354.3774-1-xiaoguang.wang@linux.alibaba.com> <6ee28cc6-3c4c-a5cb-75d4-83bccf93fb2a@kernel.dk> From: Jens Axboe Message-ID: Date: Mon, 24 Feb 2020 19:24:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 2/24/20 7:00 PM, Xiaoguang Wang wrote: > Thanks for your modified version, it works well and looks much better, > after applying this version, I also don't see this hang issue again. > From your codes, now I understand why we don't need to hold > uring_lock, thanks. Should I send this v4 version with your codes? Yeah, please send a v4, that'd be great. Thanks! -- Jens Axboe