From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77509C433DB for ; Wed, 27 Jan 2021 10:21:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3870820731 for ; Wed, 27 Jan 2021 10:21:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S314276AbhAZXDA (ORCPT ); Tue, 26 Jan 2021 18:03:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732428AbhAZTox (ORCPT ); Tue, 26 Jan 2021 14:44:53 -0500 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F37AC0617AA; Tue, 26 Jan 2021 11:43:39 -0800 (PST) Received: by mail-ed1-x531.google.com with SMTP id c6so21233910ede.0; Tue, 26 Jan 2021 11:43:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:references:from:autocrypt:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AxTMxke2lBh+WLw3QfOLyv1jNxFqDD9riUuo8aSpxYY=; b=A5qvFcktY1QEDsqUgMoUk1st9UaKimIOebQt1cKwkRsreXQeNMhxVkGCusaa/9xzle 3sISO8eOSAB0t2mL9BzBA9dcFNTk0r/EZuCAMcYOQj3Dk4AYvDGN5kIBuY/MIZhx9YZ9 MiO190KQyX94aJPmagXJvt7Hse2Dsg8ANNfJJcub+S80sJVUxoIS0hm/6qGqIi0hNB92 /KksQyuiaHTK9NsABtpi5FdrmDnvDCQ4Dpth6bJ2v24c6KfUYo2FVfO4WIfnAsXfebRb W1mR/7FoQhdJqeNuw4cjPOwXh2Xz3i0jeKpPzxe4WgYMMgBGATde0ixN+zyhg4F1LQMp kt3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=AxTMxke2lBh+WLw3QfOLyv1jNxFqDD9riUuo8aSpxYY=; b=fxJOEV714fG5GsiFDg2+4hjPGneihHZ20nqNDhXwR+Mu0KRxTUcafoHdQbG2TT0iw0 8bUpOrecJhPn3qGhX527gCPYtOPr0W2HMbZnYuCab/wzu0BMyl3UY8LcLKlZO0RlXu3U lSxPOLSrqPTeHO2RGYgWb6jKDOyVJxRRLTMhsKYjZ3Sma+sIk35p9H7MHZobMK7H8LNJ AtX3e1fwGZixq3m3pA4OJw/y+EfewgcyArWdHZhMcr+IlLULXHjZR9GJE1Ou75LrnogQ 79v1LX0L0HHLFTyWLfjT6vzHfHZ4U7mFRR78K+FD5DlOGLQmIJs4vMHR3DwsFGQyHmmm h+WQ== X-Gm-Message-State: AOAM530fp23nOt/FYFMyoKSnm9LU48rt/Pj3mDdDF4mvvF28aoG2g1Rc J6KB60CGc15BUu2uyEJpvH2EoFss+j8= X-Google-Smtp-Source: ABdhPJye22x56SYv8V1fS0kq93JtrPT26+RVrJENtrh+aje7PTCWZuIdZD8V2oe5i3GTbtjNcyLJ0A== X-Received: by 2002:a05:6402:318e:: with SMTP id di14mr5811765edb.223.1611690218044; Tue, 26 Jan 2021 11:43:38 -0800 (PST) Received: from [192.168.8.158] ([148.252.129.161]) by smtp.gmail.com with ESMTPSA id co6sm13003633edb.96.2021.01.26.11.43.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Jan 2021 11:43:36 -0800 (PST) To: Noah Goldstein Cc: noah , Jens Axboe , Alexander Viro , "open list:IO_URING" , "open list:FILESYSTEMS (VFS and infrastructure)" , open list References: <20201220065025.116516-1-goldstein.w.n@gmail.com> <0cdf2aac-6364-742d-debb-cfd58b4c6f2b@gmail.com> <20201222021043.GA139782@gmail.com> <32c9ce7e-569d-3f94-535e-00e072de772e@gmail.com> <792d56e4-b258-65b4-d0b5-dbfd728d5a02@gmail.com> From: Pavel Begunkov Autocrypt: addr=asml.silence@gmail.com; prefer-encrypt=mutual; keydata= mQINBFmKBOQBEAC76ZFxLAKpDw0bKQ8CEiYJRGn8MHTUhURL02/7n1t0HkKQx2K1fCXClbps bdwSHrhOWdW61pmfMbDYbTj6ZvGRvhoLWfGkzujB2wjNcbNTXIoOzJEGISHaPf6E2IQx1ik9 6uqVkK1OMb7qRvKH0i7HYP4WJzYbEWVyLiAxUj611mC9tgd73oqZ2pLYzGTqF2j6a/obaqha +hXuWTvpDQXqcOZJXIW43atprH03G1tQs7VwR21Q1eq6Yvy2ESLdc38EqCszBfQRMmKy+cfp W3U9Mb1w0L680pXrONcnlDBCN7/sghGeMHjGKfNANjPc+0hzz3rApPxpoE7HC1uRiwC4et83 CKnncH1l7zgeBT9Oa3qEiBlaa1ZCBqrA4dY+z5fWJYjMpwI1SNp37RtF8fKXbKQg+JuUjAa9 Y6oXeyEvDHMyJYMcinl6xCqCBAXPHnHmawkMMgjr3BBRzODmMr+CPVvnYe7BFYfoajzqzq+h EyXSl3aBf0IDPTqSUrhbmjj5OEOYgRW5p+mdYtY1cXeK8copmd+fd/eTkghok5li58AojCba jRjp7zVOLOjDlpxxiKhuFmpV4yWNh5JJaTbwCRSd04sCcDNlJj+TehTr+o1QiORzc2t+N5iJ NbILft19Izdn8U39T5oWiynqa1qCLgbuFtnYx1HlUq/HvAm+kwARAQABtDFQYXZlbCBCZWd1 bmtvdiAoc2lsZW5jZSkgPGFzbWwuc2lsZW5jZUBnbWFpbC5jb20+iQJOBBMBCAA4FiEE+6Ju PTjTbx479o3OWt5b1Glr+6UFAlmKBOQCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQ Wt5b1Glr+6WxZA//QueaKHzgdnOikJ7NA/Vq8FmhRlwgtP0+E+w93kL+ZGLzS/cUCIjn2f4Q Mcutj2Neg0CcYPX3b2nJiKr5Vn0rjJ/suiaOa1h1KzyNTOmxnsqE5fmxOf6C6x+NKE18I5Jy xzLQoktbdDVA7JfB1itt6iWSNoOTVcvFyvfe5ggy6FSCcP+m1RlR58XxVLH+qlAvxxOeEr/e aQfUzrs7gqdSd9zQGEZo0jtuBiB7k98t9y0oC9Jz0PJdvaj1NZUgtXG9pEtww3LdeXP/TkFl HBSxVflzeoFaj4UAuy8+uve7ya/ECNCc8kk0VYaEjoVrzJcYdKP583iRhOLlZA6HEmn/+Gh9 4orG67HNiJlbFiW3whxGizWsrtFNLsSP1YrEReYk9j1SoUHHzsu+ZtNfKuHIhK0sU07G1OPN 2rDLlzUWR9Jc22INAkhVHOogOcc5ajMGhgWcBJMLCoi219HlX69LIDu3Y34uIg9QPZIC2jwr 24W0kxmK6avJr7+n4o8m6sOJvhlumSp5TSNhRiKvAHB1I2JB8Q1yZCIPzx+w1ALxuoWiCdwV M/azguU42R17IuBzK0S3hPjXpEi2sK/k4pEPnHVUv9Cu09HCNnd6BRfFGjo8M9kZvw360gC1 reeMdqGjwQ68o9x0R7NBRrtUOh48TDLXCANAg97wjPoy37dQE7e5Ag0EWYoE5AEQAMWS+aBV IJtCjwtfCOV98NamFpDEjBMrCAfLm7wZlmXy5I6o7nzzCxEw06P2rhzp1hIqkaab1kHySU7g dkpjmQ7Jjlrf6KdMP87mC/Hx4+zgVCkTQCKkIxNE76Ff3O9uTvkWCspSh9J0qPYyCaVta2D1 Sq5HZ8WFcap71iVO1f2/FEHKJNz/YTSOS/W7dxJdXl2eoj3gYX2UZNfoaVv8OXKaWslZlgqN jSg9wsTv1K73AnQKt4fFhscN9YFxhtgD/SQuOldE5Ws4UlJoaFX/yCoJL3ky2kC0WFngzwRF Yo6u/KON/o28yyP+alYRMBrN0Dm60FuVSIFafSqXoJTIjSZ6olbEoT0u17Rag8BxnxryMrgR dkccq272MaSS0eOC9K2rtvxzddohRFPcy/8bkX+t2iukTDz75KSTKO+chce62Xxdg62dpkZX xK+HeDCZ7gRNZvAbDETr6XI63hPKi891GeZqvqQVYR8e+V2725w+H1iv3THiB1tx4L2bXZDI DtMKQ5D2RvCHNdPNcZeldEoJwKoA60yg6tuUquvsLvfCwtrmVI2rL2djYxRfGNmFMrUDN1Xq F3xozA91q3iZd9OYi9G+M/OA01husBdcIzj1hu0aL+MGg4Gqk6XwjoSxVd4YT41kTU7Kk+/I 5/Nf+i88ULt6HanBYcY/+Daeo/XFABEBAAGJAjYEGAEIACAWIQT7om49ONNvHjv2jc5a3lvU aWv7pQUCWYoE5AIbDAAKCRBa3lvUaWv7pfmcEACKTRQ28b1y5ztKuLdLr79+T+LwZKHjX++P 4wKjEOECCcB6KCv3hP+J2GCXDOPZvdg/ZYZafqP68Yy8AZqkfa4qPYHmIdpODtRzZSL48kM8 LRzV8Rl7J3ItvzdBRxf4T/Zseu5U6ELiQdCUkPGsJcPIJkgPjO2ROG/ZtYa9DvnShNWPlp+R uPwPccEQPWO/NP4fJl2zwC6byjljZhW5kxYswGMLBwb5cDUZAisIukyAa8Xshdan6C2RZcNs rB3L7vsg/R8UCehxOH0C+NypG2GqjVejNZsc7bgV49EOVltS+GmGyY+moIzxsuLmT93rqyII 5rSbbcTLe6KBYcs24XEoo49Zm9oDA3jYvNpeYD8rDcnNbuZh9kTgBwFN41JHOPv0W2FEEWqe JsCwQdcOQ56rtezdCJUYmRAt3BsfjN3Jn3N6rpodi4Dkdli8HylM5iq4ooeb5VkQ7UZxbCWt UVMKkOCdFhutRmYp0mbv2e87IK4erwNHQRkHUkzbsuym8RVpAZbLzLPIYK/J3RTErL6Z99N2 m3J6pjwSJY/zNwuFPs9zGEnRO4g0BUbwGdbuvDzaq6/3OJLKohr5eLXNU3JkT+3HezydWm3W OPhauth7W0db74Qd49HXK0xe/aPrK+Cp+kU1HRactyNtF8jZQbhMCC8vMGukZtWaAwpjWiiH bA== Subject: Re: [PATCH] fs: io_uring.c: Add skip option for __io_sqe_files_update Message-ID: Date: Tue, 26 Jan 2021 19:39:55 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 26/01/2021 18:43, Noah Goldstein wrote: > On Tue, Jan 26, 2021 at 12:24 PM Pavel Begunkov wrote: >> >> On 26/01/2021 17:14, Noah Goldstein wrote: >>> On Tue, Jan 26, 2021 at 7:29 AM Pavel Begunkov wrote: >>>> >>>> On 22/12/2020 02:10, Noah Goldstein wrote: >>>>> On Sun, Dec 20, 2020 at 03:18:05PM +0000, Pavel Begunkov wrote: >>>>>> On 20/12/2020 06:50, noah wrote:> From: noah >>>>>>> >>>>>>> This patch makes it so that specify a file descriptor value of -2 will >>>>>>> skip updating the corresponding fixed file index. >>>>>>> >>>>>>> This will allow for users to reduce the number of syscalls necessary >>>>>>> to update a sparse file range when using the fixed file option. >>>>>> >>>>>> Answering the github thread -- it's indeed a simple change, I had it the >>>>>> same day you posted the issue. See below it's a bit cleaner. However, I >>>>>> want to first review "io_uring: buffer registration enhancements", and >>>>>> if it's good, for easier merging/etc I'd rather prefer to let it go >>>>>> first (even if partially). >>>> >>>> Noah, want to give it a try? I've just sent a prep patch, with it you >>>> can implement it cleaner with one continue. >>> >>> Absolutely. Will get on it ASAP. >> >> Perfect. Even better if you add a liburing test > > Do you think the return value should not include files skipped? > > i.e register fds[1, 2, 3, -1] with no errors returns 4. should fds[1, > 2, -2, -1] return 3 or 4 do you think? > > Personally think the latter makes more sense. Thoughts? Let's just return @done, 4 in your case. Because otherwise locating which index has failed would be hell. And it's consistent with delete (i.e. -1). -- Pavel Begunkov