From: Jens Axboe <[email protected]>
To: "Kirill A. Shutemov" <[email protected]>
Cc: [email protected], [email protected],
[email protected]
Subject: Re: [PATCH 3/3] io_uring: add IORING_OP_MADVISE
Date: Sat, 11 Jan 2020 19:16:45 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <20200111231014.bmpxdg2juw3mxiwr@box>
On 1/11/20 4:10 PM, Kirill A. Shutemov wrote:
> On Fri, Jan 10, 2020 at 08:47:39AM -0700, Jens Axboe wrote:
>> This adds support for doing madvise(2) through io_uring. We assume that
>> any operation can block, and hence punt everything async. This could be
>> improved, but hard to make bullet proof. The async punt ensures it's
>> safe.
>>
>> Signed-off-by: Jens Axboe <[email protected]>
>
> How capability checks work with io_uring?
>
> MADV_HWPOISON requires CAP_SYS_ADMIN and I just want to make sure it will
> not open a way around.
There are two ways the request can get invoked from io_uring:
1) Inline from the system call, personality is the application (of course)
in that case.
2) Async helper, personality (creds, mm, etc) are inherited from the ring.
So it should be totally safe, and madvise is no different than the other
system calls supported in that regard.
--
Jens Axboe
next prev parent reply other threads:[~2020-01-12 2:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 15:47 [PATCHSET 0/3] io_uring: add support for madvise/fadvise Jens Axboe
2020-01-10 15:47 ` [PATCH 1/3] io_uring: add IORING_OP_FADVISE Jens Axboe
2020-01-10 15:47 ` [PATCH 2/3] mm: make do_madvise() available internally Jens Axboe
2020-01-10 15:47 ` [PATCH 3/3] io_uring: add IORING_OP_MADVISE Jens Axboe
2020-01-11 23:10 ` Kirill A. Shutemov
2020-01-12 2:16 ` Jens Axboe [this message]
2020-01-12 21:39 ` Pavel Begunkov
2020-01-13 16:58 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox