From: Olivier Langlois <[email protected]>
To: Jens Axboe <[email protected]>, Pavel Begunkov <[email protected]>
Cc: Hao Xu <[email protected]>,
io-uring <[email protected]>,
linux-kernel <[email protected]>
Subject: [PATCH v4 0/2] io_uring: Add support for napi_busy_poll
Date: Tue, 01 Mar 2022 08:47:18 -0500 [thread overview]
Message-ID: <[email protected]> (raw)
The sqpoll thread can be used for performing the napi busy poll in a
similar way that it does io polling for file systems supporting direct
access bypassing the page cache.
The other way that io_uring can be used for napi busy poll is by
calling io_uring_enter() to get events.
If the user specify a timeout value, it is distributed between polling
and sleeping by using the systemwide setting
/proc/sys/net/core/busy_poll.
The changes have been tested with this program:
https://github.com/lano1106/io_uring_udp_ping
and the result is:
Without sqpoll:
NAPI busy loop disabled:
rtt min/avg/max/mdev = 40.631/42.050/58.667/1.547 us
NAPI busy loop enabled:
rtt min/avg/max/mdev = 30.619/31.753/61.433/1.456 us
With sqpoll:
NAPI busy loop disabled:
rtt min/avg/max/mdev = 42.087/44.438/59.508/1.533 us
NAPI busy loop enabled:
rtt min/avg/max/mdev = 35.779/37.347/52.201/0.924 us
v2:
* Evaluate list_empty(&ctx->napi_list) outside io_napi_busy_loop() to keep
__io_sq_thread() execution as fast as possible
* In io_cqring_wait(), move up the sig block to avoid needless computation
if the block exits the function
* In io_cqring_wait(), protect ctx->napi_list from race condition by
splicing it into a local list
* In io_cqring_wait(), allow busy polling when uts is missing
* Fix kernel test robot issues
v3:
* Fix do_div() type mismatch warning
* Reduce uring_lock contention by creating a spinlock for protecting
napi_list
* Support correctly MULTISHOT poll requests
v4:
* Put back benchmark result in commit text
Olivier Langlois (2):
io_uring: minor io_cqring_wait() optimization
io_uring: Add support for napi_busy_poll
fs/io_uring.c | 246 ++++++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 237 insertions(+), 9 deletions(-)
base-commit: 719fce7539cd3e186598e2aed36325fe892150cf
--
2.35.1
next reply other threads:[~2022-03-01 13:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 13:47 Olivier Langlois [this message]
2022-03-01 13:47 ` [PATCH v4 1/2] io_uring: minor io_cqring_wait() optimization Olivier Langlois
2022-03-01 13:47 ` [PATCH v4 2/2] io_uring: Add support for napi_busy_poll Olivier Langlois
2022-03-01 18:31 ` Hao Xu
2022-03-01 20:06 ` Olivier Langlois
2022-03-01 20:14 ` Olivier Langlois
2022-03-02 6:27 ` Hao Xu
2022-03-02 6:38 ` Hao Xu
2022-03-02 22:03 ` Olivier Langlois
2022-03-03 7:12 ` Hao Xu
2022-03-02 5:12 ` Olivier Langlois
2022-03-02 6:35 ` Hao Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox