* [PATCH liburing] tests: don't expect multishot recv overflow backlogging
@ 2023-08-11 12:58 Pavel Begunkov
2023-08-11 16:43 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Begunkov @ 2023-08-11 12:58 UTC (permalink / raw)
To: io-uring; +Cc: Jens Axboe, asml.silence
Multishots may and are likely to complete when there is no space in CQ,
don't rely on overflows.
Signed-off-by: Pavel Begunkov <[email protected]>
---
test/recv-multishot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/recv-multishot.c b/test/recv-multishot.c
index e4a07ce..f66f131 100644
--- a/test/recv-multishot.c
+++ b/test/recv-multishot.c
@@ -271,7 +271,7 @@ static int test(struct args *args)
*/
bool const early_last = args->early_error == ERROR_EARLY_OVERFLOW &&
!args->wait_each &&
- i == N_CQE_OVERFLOW &&
+ i >= N_CQE_OVERFLOW &&
!(cqe->flags & IORING_CQE_F_MORE);
bool const should_be_last =
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH liburing] tests: don't expect multishot recv overflow backlogging
2023-08-11 12:58 [PATCH liburing] tests: don't expect multishot recv overflow backlogging Pavel Begunkov
@ 2023-08-11 16:43 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2023-08-11 16:43 UTC (permalink / raw)
To: io-uring, Pavel Begunkov
On Fri, 11 Aug 2023 13:58:30 +0100, Pavel Begunkov wrote:
> Multishots may and are likely to complete when there is no space in CQ,
> don't rely on overflows.
>
>
Applied, thanks!
[1/1] tests: don't expect multishot recv overflow backlogging
commit: b73e940c9dd4ffa8ac121db046c0788376691b99
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-11 16:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-11 12:58 [PATCH liburing] tests: don't expect multishot recv overflow backlogging Pavel Begunkov
2023-08-11 16:43 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox