From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AA45C43603 for ; Thu, 5 Dec 2019 14:09:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33B6A2245C for ; Thu, 5 Dec 2019 14:09:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="s2a2GSfz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729396AbfLEOJ7 (ORCPT ); Thu, 5 Dec 2019 09:09:59 -0500 Received: from mail-il1-f195.google.com ([209.85.166.195]:34392 "EHLO mail-il1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729240AbfLEOJ6 (ORCPT ); Thu, 5 Dec 2019 09:09:58 -0500 Received: by mail-il1-f195.google.com with SMTP id w13so3116220ilo.1 for ; Thu, 05 Dec 2019 06:09:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=NdRk0/WJY6q/NMtsungMXpX9nQb52EUzCZp5dxdBiDo=; b=s2a2GSfzBzKRVsd+y4on5r5AAqvHvkht2ps+r4RS1KKyGeBVN8Z1qlKDyUziyi3Zc6 yWi9p9aDDyvVmDydac/apXnIR6wLQp9kVdSOBVNS5iVPCj4kXHoPV/ngMBUO/ZLO777X jwsvUMR29lHN5ATMpbKzK0E6rACPmzSnbGftP9d4Dq24+RqiRHs6gusv8y2h6PVQjn0G adNZbUX8kpKRnIt8RPYyE4dBcheAx8CAlQH16U+BZvIk0IcCeUdDw/l9FRBJaDZlOVg1 p9ZAKiSGSXdObAu/1NIPuiNMTq5Ca1rr0x5jRS57Rk8WGym72d6zio+txaRLEOgsueSB 0ZRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NdRk0/WJY6q/NMtsungMXpX9nQb52EUzCZp5dxdBiDo=; b=GZAMNNxHrogfu+kTFINCT+5E9o4Fm916oPuXF2klNMZPoi487dvEMLKLs5psF32VAG 6wDijs4HPK1W/RLKM12BTGBGiqZkul25gr+Xyhh+P4pJ55s5vWn/QualuqHbuH3uAchw 2sTQBcqEfrqcL60cmNT/jtsNSZllbwUAqhb8IZ5XrfPzIsUxpCo8rpKiyzYjgjqmM8wh wJhYxedIbiB36WUsg30CgR9e8fAGp6JRrMXPdhvQHaGBflOfUsI+Mx09i1hA/XC5trro RnMMkAcmIbdOEHDBrZMxVK+UKy1KVa3/Jx7pkUbFE8KyT0lujt+MtQHdZjtH2t7yzYpu 8r+Q== X-Gm-Message-State: APjAAAVZhuqjbALs0L8vdRt8mSkgwa+8TRzQtxFWLkNEFy6VZqGjnWAV 0f9AdFDTtJBUKYp1JjEPZy4kKw== X-Google-Smtp-Source: APXvYqxka6pf9MNXTzfSzkKUdtu/jgSk3q+8bdm4H/e/EfMW/H5sh1ar7k3KBKI1kLw1wDMVkjBH0g== X-Received: by 2002:a92:9107:: with SMTP id t7mr9019531ild.51.1575554998080; Thu, 05 Dec 2019 06:09:58 -0800 (PST) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id s8sm2814777ilq.14.2019.12.05.06.09.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Dec 2019 06:09:57 -0800 (PST) Subject: Re: [PATCH] io_uring: hook all linked requests via link_list To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: <49ba20e17803a7caf1cb87792b36dd40b4a99806.1575551693.git.asml.silence@gmail.com> From: Jens Axboe Message-ID: Date: Thu, 5 Dec 2019 07:09:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <49ba20e17803a7caf1cb87792b36dd40b4a99806.1575551693.git.asml.silence@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 12/5/19 6:16 AM, Pavel Begunkov wrote: > Links are created by chaining requests through req->list with an > exception that head uses req->link_list. (e.g. link_list->list->list) > Because of that, io_req_link_next() needs complex splicing to advance. > > Link them all through list_list. Also, it seems to be simpler and more > consistent IMHO. Agree, much easier to grok and verify. Applied, thanks. -- Jens Axboe