Re: [PATCH v4 1/6] io_uring/mock: add basic infra for test mock files

[Jens Axboe <axboe@kernel.dk>]

On 5/30/25 12:21 PM, Pavel Begunkov wrote:
> On 5/30/25 19:04, Keith Busch wrote:
>> On Fri, May 30, 2025 at 01:51:58PM +0100, Pavel Begunkov wrote:
>>> +++ b/io_uring/mock_file.h
>>> @@ -0,0 +1,22 @@
>>> +#ifndef IOU_MOCK_H
>>> +#define IOU_MOCK_H
>>> +
>>> +#include <linux/types.h>
>>> +
>>> +struct io_uring_mock_probe {
>>> +    __u64        features;
>>> +    __u64        __resv[9];
>>> +};
>>> +
>>> +struct io_uring_mock_create {
>>> +    __u32        out_fd;
>>> +    __u32        flags;
>>> +    __u64        __resv[15];
>>> +};
>>> +
>>> +enum {
>>> +    IORING_MOCK_MGR_CMD_PROBE,
>>> +    IORING_MOCK_MGR_CMD_CREATE,
>>> +};
>>> +
>>> +#endif
>>
>> Shouldn't this go in a linux/uapi header instead?
> 
> Depends on whether we want distribute it to machines where it's
> not supposed to be enabled ever. I couldn't find any notion of
> debug headers in header installation, what people usually do
> in this case?

It still needs to go in uapi, as it is a user api of sorts. Otherwise
we'd need to duplicate it in test programs.

-- 
Jens Axboe