public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH v2] io_uring: fix bug of wrong BUILD_BUG_ON check of __REQ_F_LAST_BIT
@ 2021-09-07  3:22 Hao Xu
  2021-09-10 11:50 ` Hao Xu
  2021-09-10 12:26 ` Jens Axboe
  0 siblings, 2 replies; 3+ messages in thread
From: Hao Xu @ 2021-09-07  3:22 UTC (permalink / raw)
  To: Jens Axboe; +Cc: io-uring, Pavel Begunkov, Joseph Qi

Build check of __REQ_F_LAST_BIT should be large than not equal or large
than.

Signed-off-by: Hao Xu <[email protected]>
---
 fs/io_uring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 2bde732a1183..d159d9204e07 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -10643,7 +10643,7 @@ static int __init io_uring_init(void)
 	BUILD_BUG_ON(SQE_VALID_FLAGS >= (1 << 8));
 
 	BUILD_BUG_ON(ARRAY_SIZE(io_op_defs) != IORING_OP_LAST);
-	BUILD_BUG_ON(__REQ_F_LAST_BIT >= 8 * sizeof(int));
+	BUILD_BUG_ON(__REQ_F_LAST_BIT > 8 * sizeof(int));
 
 	req_cachep = KMEM_CACHE(io_kiocb, SLAB_HWCACHE_ALIGN | SLAB_PANIC |
 				SLAB_ACCOUNT);
-- 
2.24.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] io_uring: fix bug of wrong BUILD_BUG_ON check of __REQ_F_LAST_BIT
  2021-09-07  3:22 [PATCH v2] io_uring: fix bug of wrong BUILD_BUG_ON check of __REQ_F_LAST_BIT Hao Xu
@ 2021-09-10 11:50 ` Hao Xu
  2021-09-10 12:26 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Hao Xu @ 2021-09-10 11:50 UTC (permalink / raw)
  To: Jens Axboe; +Cc: io-uring, Pavel Begunkov, Joseph Qi

ping
在 2021/9/7 上午11:22, Hao Xu 写道:
> Build check of __REQ_F_LAST_BIT should be large than not equal or large
> than.
> 
> Signed-off-by: Hao Xu <[email protected]>
> ---
>   fs/io_uring.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 2bde732a1183..d159d9204e07 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -10643,7 +10643,7 @@ static int __init io_uring_init(void)
>   	BUILD_BUG_ON(SQE_VALID_FLAGS >= (1 << 8));
>   
>   	BUILD_BUG_ON(ARRAY_SIZE(io_op_defs) != IORING_OP_LAST);
> -	BUILD_BUG_ON(__REQ_F_LAST_BIT >= 8 * sizeof(int));
> +	BUILD_BUG_ON(__REQ_F_LAST_BIT > 8 * sizeof(int));
>   
>   	req_cachep = KMEM_CACHE(io_kiocb, SLAB_HWCACHE_ALIGN | SLAB_PANIC |
>   				SLAB_ACCOUNT);
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] io_uring: fix bug of wrong BUILD_BUG_ON check of __REQ_F_LAST_BIT
  2021-09-07  3:22 [PATCH v2] io_uring: fix bug of wrong BUILD_BUG_ON check of __REQ_F_LAST_BIT Hao Xu
  2021-09-10 11:50 ` Hao Xu
@ 2021-09-10 12:26 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2021-09-10 12:26 UTC (permalink / raw)
  To: Hao Xu; +Cc: io-uring, Pavel Begunkov, Joseph Qi

On 9/6/21 9:22 PM, Hao Xu wrote:
> Build check of __REQ_F_LAST_BIT should be large than not equal or large
> than.

Thanks, applied with a bit of commit message massaging.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-10 12:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-07  3:22 [PATCH v2] io_uring: fix bug of wrong BUILD_BUG_ON check of __REQ_F_LAST_BIT Hao Xu
2021-09-10 11:50 ` Hao Xu
2021-09-10 12:26 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox