From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Subject: Re: [PATCH 0/7] further ring init cleanups
Date: Wed, 12 Nov 2025 12:33:58 -0700 [thread overview]
Message-ID: <d1f1392e-c14a-47a7-83c1-e9f9e0f3b852@kernel.dk> (raw)
In-Reply-To: <cover.1762947814.git.asml.silence@gmail.com>
On 11/12/25 5:45 AM, Pavel Begunkov wrote:
> There are several goals for this patch set. It deduplicates ring size and
> offset calculations between ring setup and resizing. It moves most of
> verification earlier before any allocations, which usually means simpler
> error handling. And it keeps the logic localised instead of spreading it
> across the file.
>
> Pavel Begunkov (7):
> io_uring: refactor rings_size nosqarray handling
> io_uring: use size_add helpers for ring offsets
> io_uring: convert params to pointer in ring reisze
> io_uring: introduce struct io_ctx_config
> io_uring: keep ring laoyut in a structure
> io_uring: pre-calculate scq layout
> io_uring: move cq/sq user offset init around
>
> io_uring/io_uring.c | 137 ++++++++++++++++++++++++--------------------
> io_uring/io_uring.h | 19 +++++-
> io_uring/register.c | 65 +++++++++------------
> 3 files changed, 119 insertions(+), 102 deletions(-)
All looks pretty straightforward to me. I'm going to let it simmer for a
day or so to give other folks a chance to take a look too.
--
Jens Axboe
next prev parent reply other threads:[~2025-11-12 19:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 12:45 [PATCH 0/7] further ring init cleanups Pavel Begunkov
2025-11-12 12:45 ` [PATCH 1/7] io_uring: refactor rings_size nosqarray handling Pavel Begunkov
2025-11-12 12:45 ` [PATCH 2/7] io_uring: use size_add helpers for ring offsets Pavel Begunkov
2025-11-12 12:45 ` [PATCH 3/7] io_uring: convert params to pointer in ring reisze Pavel Begunkov
2025-11-12 12:45 ` [PATCH 4/7] io_uring: introduce struct io_ctx_config Pavel Begunkov
2025-11-12 12:45 ` [PATCH 5/7] io_uring: keep ring laoyut in a structure Pavel Begunkov
2025-11-12 12:45 ` [PATCH 6/7] io_uring: pre-calculate scq layout Pavel Begunkov
2025-11-12 12:45 ` [PATCH 7/7] io_uring: move cq/sq user offset init around Pavel Begunkov
2025-11-12 19:33 ` Jens Axboe [this message]
2025-11-13 14:28 ` [PATCH 0/7] further ring init cleanups Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1f1392e-c14a-47a7-83c1-e9f9e0f3b852@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox