From: Pavel Begunkov <[email protected]>
To: [email protected]
Cc: Jens Axboe <[email protected]>, [email protected]
Subject: [PATCH liburing 2/7] send: improve buffer iteration
Date: Tue, 21 Feb 2023 01:05:53 +0000 [thread overview]
Message-ID: <d2d1c90856ce4f511eed5c7ffd7d829215f67f3a.1676941370.git.asml.silence@gmail.com> (raw)
In-Reply-To: <[email protected]>
Signed-off-by: Pavel Begunkov <[email protected]>
---
test/send-zerocopy.c | 42 ++++++++++++++++++++++++------------------
1 file changed, 24 insertions(+), 18 deletions(-)
diff --git a/test/send-zerocopy.c b/test/send-zerocopy.c
index 2e30e49..e663be7 100644
--- a/test/send-zerocopy.c
+++ b/test/send-zerocopy.c
@@ -484,6 +484,7 @@ static int test_inet_send(struct io_uring *ring)
struct sockaddr_storage addr;
int sock_client = -1, sock_server = -1;
int ret, j, i;
+ int buf_index;
for (j = 0; j < 32; j++) {
bool ipv6 = j & 1;
@@ -510,20 +511,19 @@ static int test_inet_send(struct io_uring *ring)
sock_server = tmp_sock;
}
- for (i = 0; i < 4096; i++) {
+ for (i = 0; i < 1024; i++) {
bool regbuf;
- conf.buf_index = i & 3;
+ conf.use_sendmsg = i & 1;
+ conf.poll_first = i & 2;
conf.fixed_buf = i & 4;
conf.addr = (i & 8) ? &addr : NULL;
conf.cork = i & 16;
conf.mix_register = i & 32;
conf.force_async = i & 64;
- conf.use_sendmsg = i & 128;
- conf.zc = i & 256;
- conf.iovec = i & 512;
- conf.long_iovec = i & 1024;
- conf.poll_first = i & 2048;
+ conf.zc = i & 128;
+ conf.iovec = i & 256;
+ conf.long_iovec = i & 512;
conf.tcp = tcp;
regbuf = conf.mix_register || conf.fixed_buf;
@@ -539,10 +539,6 @@ static int test_inet_send(struct io_uring *ring)
if (conf.addr && !has_sendmsg)
continue;
}
- if (conf.buf_index == BUF_T_LARGE && !tcp)
- continue;
- if (!buffers_iov[conf.buf_index].iov_base)
- continue;
if (tcp && (conf.cork || conf.addr))
continue;
if (conf.mix_register && (!conf.cork || conf.fixed_buf))
@@ -554,13 +550,23 @@ static int test_inet_send(struct io_uring *ring)
if (msg_zc_set && !conf.zc)
continue;
- ret = do_test_inet_send(ring, sock_client, sock_server, &conf);
- if (ret) {
- fprintf(stderr, "send failed fixed buf %i, conn %i, addr %i, "
- "cork %i\n",
- conf.fixed_buf, client_connect, !!conf.addr,
- conf.cork);
- return 1;
+ for (buf_index = 0; buf_index < ARRAY_SIZE(buffers_iov); buf_index++) {
+ size_t len = buffers_iov[buf_index].iov_len;
+
+ if (!buffers_iov[buf_index].iov_base)
+ continue;
+ if (!tcp && len > 4 * page_sz)
+ continue;
+
+ conf.buf_index = buf_index;
+ ret = do_test_inet_send(ring, sock_client, sock_server, &conf);
+ if (ret) {
+ fprintf(stderr, "send failed fixed buf %i, "
+ "conn %i, addr %i, cork %i\n",
+ conf.fixed_buf, client_connect,
+ !!conf.addr, conf.cork);
+ return 1;
+ }
}
}
--
2.39.1
next prev parent reply other threads:[~2023-02-21 1:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 1:05 [PATCH liburing 0/7] test sends with huge pages Pavel Begunkov
2023-02-21 1:05 ` [PATCH liburing 1/7] tests/send: don't use a constant for page size Pavel Begunkov
2023-02-21 1:05 ` Pavel Begunkov [this message]
2023-02-21 1:05 ` [PATCH liburing 3/7] send: test send with hugetlb Pavel Begunkov
2023-02-21 1:05 ` [PATCH liburing 4/7] examples/zc: add a hugetlb option Pavel Begunkov
2023-02-21 1:05 ` [PATCH liburing 5/7] test/send: don't use SO_ZEROCOPY if not available Pavel Begunkov
2023-02-21 1:05 ` [PATCH liburing 6/7] tests/send: improve error reporting Pavel Begunkov
2023-02-21 1:05 ` [PATCH liburing 7/7] tests/send: sends with offsets Pavel Begunkov
2023-02-22 16:54 ` [PATCH liburing 0/7] test sends with huge pages Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2d1c90856ce4f511eed5c7ffd7d829215f67f3a.1676941370.git.asml.silence@gmail.com \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox