* Issue with splice 32-bit compatability?
@ 2020-02-28 15:16 Jens Axboe
2020-02-28 15:25 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2020-02-28 15:16 UTC (permalink / raw)
To: io-uring, Pavel Begunkov
Hey Pavel,
Since I yesterday found that weirdness with networking and using
a separate flag for compat mode, I went to check everything else.
Outside of all the syzbot reproducers not running in 32-bit mode,
the only other error was splice:
splice: returned -29, expected 16384
basic splice-copy failed
test_splice failed -29 0
Test splice failed with ret 227
Can you take a look? I just edit test/Makefile and src/Makefile and
add -m32 to the CFLAGS for testing.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Issue with splice 32-bit compatability?
2020-02-28 15:16 Issue with splice 32-bit compatability? Jens Axboe
@ 2020-02-28 15:25 ` Jens Axboe
2020-02-28 22:52 ` Pavel Begunkov
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2020-02-28 15:25 UTC (permalink / raw)
To: io-uring, Pavel Begunkov
On 2/28/20 8:16 AM, Jens Axboe wrote:
> Hey Pavel,
>
> Since I yesterday found that weirdness with networking and using
> a separate flag for compat mode, I went to check everything else.
> Outside of all the syzbot reproducers not running in 32-bit mode,
> the only other error was splice:
>
> splice: returned -29, expected 16384
> basic splice-copy failed
> test_splice failed -29 0
> Test splice failed with ret 227
>
> Can you take a look? I just edit test/Makefile and src/Makefile and
> add -m32 to the CFLAGS for testing.
It's in the liburing prep, fixed it:
https://git.kernel.dk/cgit/liburing/commit/?id=566180209fc4d9e3ee8852315a4411ee0c3d5510
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Issue with splice 32-bit compatability?
2020-02-28 15:25 ` Jens Axboe
@ 2020-02-28 22:52 ` Pavel Begunkov
0 siblings, 0 replies; 3+ messages in thread
From: Pavel Begunkov @ 2020-02-28 22:52 UTC (permalink / raw)
To: Jens Axboe, io-uring
On 28/02/2020 18:25, Jens Axboe wrote:
> On 2/28/20 8:16 AM, Jens Axboe wrote:
>> Hey Pavel,
>>
>> Since I yesterday found that weirdness with networking and using
>> a separate flag for compat mode, I went to check everything else.
>> Outside of all the syzbot reproducers not running in 32-bit mode,
>> the only other error was splice:
>>
>> splice: returned -29, expected 16384
>> basic splice-copy failed
>> test_splice failed -29 0
>> Test splice failed with ret 227
>>
>> Can you take a look? I just edit test/Makefile and src/Makefile and
>> add -m32 to the CFLAGS for testing.
>
> It's in the liburing prep, fixed it:
>
> https://git.kernel.dk/cgit/liburing/commit/?id=566180209fc4d9e3ee8852315a4411ee0c3d5510
A subtle one, great you found it!
--
Pavel Begunkov
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-28 22:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-28 15:16 Issue with splice 32-bit compatability? Jens Axboe
2020-02-28 15:25 ` Jens Axboe
2020-02-28 22:52 ` Pavel Begunkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox