public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Begunkov <asml.silence@gmail.com>
To: Dylan Yudaken <dyudaken@gmail.com>,
	axboe@kernel.dk, io-uring@vger.kernel.org
Subject: Re: [PATCH] io_uring: remove unneeded io_send_zc accounting
Date: Mon, 16 Feb 2026 11:43:29 +0000	[thread overview]
Message-ID: <d3c656f6-5ca3-4fc3-b734-25547aec4741@gmail.com> (raw)
In-Reply-To: <c8c715e9-1aa3-48d1-b080-8844be893571@gmail.com>

On 2/15/26 23:39, Pavel Begunkov wrote:
> On 2/15/26 23:15, Dylan Yudaken wrote:
>> zc->len and zc->buf are not actually used once you get to the retry
>> stage. The buffer remains in kmsg->msg.msg_iter, which is setup in
>> io_send_setup.
>> Note: it still seems needed in io_send due to io_send_select_buffer
>> needing it (for the len parameter).
>>
>> Signed-off-by: Dylan Yudaken <dyudaken@gmail.com>
>> ---
>> Hi,
>>
>> I'm reasonably sure this is correct - but I think Pavel might want to
>> double check that I did not miss anything. The tests seem to pass with no
>> changes.
> 
> Looks good, I'll have a look tomorrow

Reviewed-by: Pavel Begunkov <asml.silence@gmail.com>

I like the change, and we should get rid of duplication between
send and sendmsg on top.

-- 
Pavel Begunkov


  reply	other threads:[~2026-02-16 11:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-15 23:15 [PATCH] io_uring: remove unneeded io_send_zc accounting Dylan Yudaken
2026-02-15 23:39 ` Pavel Begunkov
2026-02-16 11:43   ` Pavel Begunkov [this message]
2026-02-15 23:51 ` Jens Axboe
2026-02-16 15:29 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3c656f6-5ca3-4fc3-b734-25547aec4741@gmail.com \
    --to=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=dyudaken@gmail.com \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox